ORT should fail with missing location parameters

[jhg03a]

I'm submitting a ...

• bug report
• new feature / enhancement request
• improvement request (usability, performance, tech debt, etc.)
• other

Traffic Control components affected ...

• CDN in a Box
• Documentation
• Grove
• Traffic Control Client
• Traffic Monitor
• Traffic Ops
• Traffic Ops ORT
• Traffic Portal
• Traffic Router
• Traffic Stats
• Traffic Vault
• unknown

Current behavior:

If there is a missing mid header rewrite location parameter somehow that's referenced by the ATS remap config, ORT is ok with this and ATS just fails to reload properly.

Expected / new behavior:

ORT should fail if location parameters are missing.

Minimal reproduction of the problem with instructions:

Anything else:

[ocket8888]

Seems like that ought to fail at the config generation step; wherever that's occurring these days.

[jhg03a]

Header rewrite files and remap.config are considered separate files during config generation.

[ocket8888]

Oh, I misunderstood. I thought you were saying there was something wrong syntactically with the file's contents. Parameter meaning ATC Parameter, got it.

[mitchell852]

@rob05c - is this still relevant with all the ort/atstccfg changes?

[rob05c]

Yeah, we still use location parameters, and ORT/config gen still "succeeds" even if they're missing.

We need to just get rid of DS location params, and infer them. But it doesn't yet.

[rob05c]

Seems like that ought to fail at the config generation step

Yeah, I made the ORT Config Gen emulate the old as much as possible, for safety.

I think it should log an Error, but keep going, for this kind of thing. We shouldn't break everything for one bad DS, and we should always try to keep the CDN up. But it should definitely log an error, and people should make alarms for that.