Skip to content

TINKERPOP-3095: Provide a path for selecting script engine for traversals in TP4 - #3727

Open
Iryna-Kahamlyk wants to merge 2 commits into
apache:masterfrom
Iryna-Kahamlyk:TINKERPOP-3095
Open

Iryna-Kahamlyk wants to merge 2 commits into
apache:masterfrom
Iryna-Kahamlyk:TINKERPOP-3095

Conversation

@Iryna-Kahamlyk

Copy link
Copy Markdown
Contributor

JIRA: https://issues.apache.org/jira/browse/TINKERPOP-3095

Summary

Traversal-based remote requests can now choose the server script engine, as string queries already could via RequestOptions. This works in Java, Python, .NET, Go and JavaScript, in two ways:

  • Per traversal source: g.with("language", "gremlin-lang")
  • Per connection: a default for every traversal on a DriverRemoteConnection
    • Java: DriverRemoteConnection.using(cluster, "g", "gremlin-lang")
    • Python: language='gremlin-lang'
    • .NET: language: "gremlin-lang"
    • Go: settings.RequestLanguage
    • JavaScript: { language: 'gremlin-lang' }

A value set with with() overrides the connection default. If neither is set, nothing changes: .NET, Go and JavaScript still send gremlin-lang, and Java and Python let the server choose.

Bug fix: gremlin-go and gremlin-javascript silently dropped with("language", ...) from remote traversals because their option allow-lists omitted it. It is now sent.

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.74%. Comparing base (a28cd1f) to head (0023038).
⚠️ Report is 740 commits behind head on master.

Files with missing lines Patch % Lines
.../gremlin/driver/remote/DriverRemoteConnection.java 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3727      +/-   ##
============================================
+ Coverage     76.35%   76.74%   +0.38%     
- Complexity    13424    14350     +926     
============================================
  Files          1012     1037      +25     
  Lines         60341    64839    +4498     
  Branches       7075     7705     +630     
============================================
+ Hits          46076    49758    +3682     
- Misses        11548    11987     +439     
- Partials       2717     3094     +377     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Iryna-Kahamlyk
Iryna-Kahamlyk marked this pull request as ready for review October 19, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants