TINKERPOP-2992 Fixed orderability bug on OffsetDateTime#3303
Open
spmallette wants to merge 1 commit into3.8-devfrom
Open
TINKERPOP-2992 Fixed orderability bug on OffsetDateTime#3303spmallette wants to merge 1 commit into3.8-devfrom
spmallette wants to merge 1 commit into3.8-devfrom
Conversation
Fixed javascript translator for uuid. Added testing on date, set, uuid.
kenhuuu
reviewed
Feb 6, 2026
| | bar | | ||
| | foo | | ||
| | zzz | | ||
| | uuid[5100808b-62f9-42b7-957e-ed66c30f40d1] | |
Contributor
There was a problem hiding this comment.
Nit: It doesn't look like UUID is mentioned in the gremlin-semantics orderability section so it's not immediately obvious if this is where it belongs. Would be best to add clarification in the documentation.
kenhuuu
reviewed
Feb 6, 2026
| * <li>Makes enums explicit with their proper name</li> | ||
| * </ul> | ||
| * <p/> | ||
| * Assumes use of https://www.npmjs.com/package/uuid library for UUID handling. |
Contributor
There was a problem hiding this comment.
I think we are trying to avoid using npm packages for JavaScript types as it can stop the GLV from being used in the browser.
Contributor
|
VOTE +1, pending nits. I only did a quick overview of the gremlin-go section as I don't really know that language well, would be great is someone else could review that section more closely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2992
Fixed javascript translator for uuid. Added testing on date, set, uuid.
VOTE +1