Skip to content

Update Maven plugins (mostly minor version updates) #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ceefour
Copy link
Contributor

@ceefour ceefour commented Mar 15, 2016

No description provided.

@spmallette
Copy link
Contributor

I see you changed the asciidoctor-maven-plugin version - that's a pretty major version change - did you build the documentation with bin/process-docs.sh to be sure that it works and everything still looks good?

@ceefour
Copy link
Contributor Author

ceefour commented Mar 20, 2016

@spmallette I've left asciidoctor as before. I'll make another pull request just for asciidoctor when I've verified asciidoctor process-docs.sh working.

@okram
Copy link
Contributor

okram commented Mar 22, 2016

VOTE +1.

@spmallette
Copy link
Contributor

Did some basic tests that all seemed to look ok after this change:

  • mvn clean install
  • ran integration tests for gremlin server
  • process-docs.sh worked but only after i reverted to hadoop 2.7.1 (that may be an open issue still from Update hadoop to 2.7.2 #262 - @okram you may want to review that again )
  • tried out the distributions that were created ever so lightly

@ceefour i have to be honest. i don't like to arbitrarily bump versions of things without reasons. TinkerPop has been burned on that so many times before where pull requests like this one were merged and we ended up with surprises on release day......and as I'm typically the release manager these days, i don't want surprises 😉

were you actually trying to fix something here with these changes? did you look at the release notes of each of these projects to see what these new releases are providing to us? bug fixes? features? can you provide some synopsis of what those are?

@spmallette
Copy link
Contributor

Taking back what I said about not being able to generate docs on 2.7.2 - just got it to work. other issues/questions i posed still stand.

@spmallette
Copy link
Contributor

@ceefour please have a look at my last couple of comments as i still have open questions about this PR. until then my VOTE is -1 and we should probably just close this. thanks.

@ceefour
Copy link
Contributor Author

ceefour commented Apr 4, 2016

Okay.. not fixing a non-broken thing.. :)

@ceefour ceefour closed this Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants