Skip to content

THRIFT-5909: Addressed discrepancy in the non-accelerated union implementation #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpumuk wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

THRIFT-5909: Addressed discrepancy in the non-accelerated union implementation #3269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/rb/lib/thrift/union.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ def write(oprot)
fid = self.name_to_id(@setfield.to_s)

field_info = struct_fields[fid]
raise "set_field is not valid for this union!" unless field_info

type = field_info[:type]
if is_container? type
oprot.write_field_begin(@setfield, type, fid)
Expand Down
Loading