Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections #2266

Closed
wants to merge 3 commits into from

Conversation

belugabehr
Copy link
Contributor

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x ] Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented Dec 23, 2020

@belugabehr There seem no objections from anyone. What about triggering the CI again and commit if all is green?
@ java devs: Any comments on this change?

@belugabehr
Copy link
Contributor Author

@Jens-G Thank you for your interest. I believe there were some comment about moving the back-off functionality to the client code, which is not inappropriate, but I have not yet had the time to implement.

Happy to get this part in first if that's OK.

@belugabehr
Copy link
Contributor Author

@Jens-G Any ideas on how to kick off the automated build/test suite?

@belugabehr
Copy link
Contributor Author

OK. Looks like there was a lag. All good now.

I ran into some hardship recently trying to debug an application build on Thrift server. I have some ideas for making it more debug-able, but need this in first and then can build on it.

@belugabehr
Copy link
Contributor Author

@Jens-G Should be good to go now. C++ failures only.

@Jens-G Jens-G closed this in 7ae1ec3 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants