Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4967: Node.js tutorial server fails if the zip function invoked #1887

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Oct 4, 2019

Client: nodejs

This PR fixes tutorial/nodejs/NodeServer.js not to fail when receiving an invocation for the zip function.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

@dcelasun dcelasun merged commit 4fc4661 into apache:master Oct 8, 2019
@dcelasun
Copy link
Member

dcelasun commented Oct 8, 2019

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants