Skip to content

TEZ-4743: Refactor ProfileServlet and ProfileOutputServlet to use standard response.sendError API#527

Open
Aggarwal-Raghav wants to merge 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4743
Open

TEZ-4743: Refactor ProfileServlet and ProfileOutputServlet to use standard response.sendError API#527
Aggarwal-Raghav wants to merge 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4743

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor
  • Replaced manual error writing with the standard, built-in response.sendError(...) API in both servlets
  • Removed the obsolete writeMessage() and PrintStream logic
  • If the ?file= parameter is missing, the servlet now correctly returns a 400 Bad Request instead of incorrectly returning a 200 OK success code

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 4m 15s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 6m 16s master passed
-1 ❌ compile 2m 49s /branch-compile-root.txt root in master failed.
-0 ⚠️ checkstyle 0m 27s /buildtool-branch-checkstyle-tez-common.txt The patch fails to run checkstyle in tez-common
+1 💚 javadoc 0m 31s master passed
+0 🆗 spotbugs 1m 4s tez-common in master has 13 extant spotbugs warnings.
_ Patch Compile Tests _
-1 ❌ mvninstall 1m 17s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 codespell 1m 59s No new issues.
-1 ❌ compile 0m 22s /patch-compile-root.txt root in the patch failed.
-1 ❌ javac 0m 22s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 35s /buildtool-patch-checkstyle-tez-common.txt The patch fails to run checkstyle in tez-common
-1 ❌ javadoc 0m 31s /patch-javadoc-tez-common.txt tez-common in the patch failed.
-1 ❌ spotbugs 0m 44s /patch-spotbugs-tez-common.txt tez-common in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 14s /patch-unit-root.txt root in the patch failed.
+0 🆗 asflicense 0m 16s ASF License check generated no output?
23m 8s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-527/1/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
uname Linux c478e300147c 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / b9d8c0f
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-527/1/testReport/
Max. process+thread count 116 (vs. ulimit of 5500)
modules C: tez-common U: tez-common
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-527/1/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

this looks good so far 👍 assuming a rebase

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor Author

Will do in an hour

…ndard response.sendError API

- Replaced manual error writing with the standard, built-in response.sendError(...) API in both servlets
- Removed the obsolete writeMessage() and PrintStream logic
- If the `?file=` parameter is missing, the servlet now correctly returns a 400 Bad Request instead of incorrectly returning a 200 OK success code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants