refactor(frontend): remove unused fs-extra devDependency - #5842
Merged
Conversation
github-actions
Bot
added
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5842 +/- ##
============================================
- Coverage 53.88% 53.81% -0.07%
+ Complexity 2753 2722 -31
============================================
Files 1099 1099
Lines 42541 42541
Branches 4577 4577
============================================
- Hits 22922 22894 -28
- Misses 18286 18307 +21
- Partials 1333 1340 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ma77Ball
marked this pull request as ready for review
June 21, 2026 08:42
Yicong-Huang
approved these changes
Jun 21, 2026
Yicong-Huang
left a comment
Yicong-Huang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clean up!
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 24, 2026
### What changes were proposed in this PR? - Remove the unused `fs-extra` (10.0.1) devDependency from `frontend/package.json`; it is never imported or referenced in `src/`, `build-version.js`, `custom-webpack.config.js`, any config, or any npm script. It was introduced by apache#899 and we have replaced it in apache#3613 ### Any related issues, documentation, discussions? Closes: apache#5841 ### How was this PR tested? - Run `yarn install` in `frontend/`, expect the only `yarn.lock` change to be removal of the direct `fs-extra@npm:10.0.1` block plus the project's reference (verify with `git diff frontend/yarn.lock`). - Run `yarn build` in `frontend/` (production `ng build`), expect exit code 0 with no new errors; this confirms nothing in the source or build pipeline depends on the direct `fs-extra` dependency. - Run `grep -rn "fs-extra" frontend/src frontend/build-version.js frontend/custom-webpack.config.js`, expect no matches. ### Was this PR authored or co-authored using generative AI tooling? Co-authored with Claude Opus 4.8 in compliance with ASF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
fs-extra(10.0.1) devDependency fromfrontend/package.json; it is never imported or referenced insrc/,build-version.js,custom-webpack.config.js, any config, or any npm script. It was introduced by Populating Git Commit Hash in the frontend #899 and we have replaced it in Use build number to replace git hash display on the UI #3613Any related issues, documentation, discussions?
Closes: #5841
How was this PR tested?
yarn installinfrontend/, expect the onlyyarn.lockchange to be removal of the directfs-extra@npm:10.0.1block plus the project's reference (verify withgit diff frontend/yarn.lock).yarn buildinfrontend/(productionng build), expect exit code 0 with no new errors; this confirms nothing in the source or build pipeline depends on the directfs-extradependency.grep -rn "fs-extra" frontend/src frontend/build-version.js frontend/custom-webpack.config.js, expect no matches.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF