-
Notifications
You must be signed in to change notification settings - Fork 113
feat(bin): add some helper scripts #3890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will any other part of the system use those scripts?
If not, why do we need a script to output TEXERA_HOME? It's more meaningful to have a script that sets TEXERA_HOME rather than outputting it.
If you have any future plans, you should explain them in the PR description. Those three scripts are not useful on their own.
|
Fix-format uses resolve home.
The idea is to let more scripts use those scripts inside bin/utils.
We don’t need a script to set TEXERA_HOME. It’s an environment variable,
one can set with command line.
…On Tue, Oct 14, 2025 at 6:40 PM Xinyuan Lin ***@***.***> wrote:
***@***.**** commented on this pull request.
Will those scripts be used by any other part of the system?
If not, why do we need a script to output TEXERA_HOME? It's more
meaningful to have a script that sets TEXERA_HOME rather than outputting it.
—
Reply to this email directly, view it on GitHub
<#3890 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGPVNLYNA5HZNMYLFHPUFT3XWQXNAVCNFSM6AAAAACJALJT2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMZYGA3TINZVGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
aglinxinyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
So I think the main part of this PR is to add fix-format.sh, and the other two scripts are just helpers for it, but they can also be reused by other scripts.
|
Thanks. I view it the other way: the main purpose is to introduce the two
helper scripts. They are critical building blocks for other scripts.
And fix-format.sh is just a demo of how to use the other two util scripts.
fix-format.sh is just a syntax sugar of all linter commands consolidated
into one handy script.
…On Tue, Oct 14, 2025 at 6:47 PM Xinyuan Lin ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM!
So I think the main part of this PR is to add fix-format.sh, and the
other two scripts are just helpers for it, but they can also be reused by
other scripts.
—
Reply to this email directly, view it on GitHub
<#3890 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGPVNIGE2ZGUEYZD4GSTRL3XWRTRAVCNFSM6AAAAACJALJT2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMZYGA4DIOBVHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Ok. Can you explain that in the PR description? Having bullet points of 1.2.3 gave me the impression that they are at the same level and they are all the same type of helper script, but in fact, utils and fix-format are quite different. |
This PR adds two useful utility scripts:
bin/utils/resolve-texera-home.sh, automatically resolveTEXERA_HOME.bin/utils/texera-logging.sh, a colorful logging helper with Texera line header:Texera ▶.To demonstrate how to use those two scripts, I have included an example script that uses the utility scripts above.
bin/fix-format.sh, a handy script to fix formats, can optionally choose which component to fix.By default, it is recommended to execute scripts from root. For example, use
bin/fix-format.shto fix format. But all the scripts in this PR should also be working insidebindirectory as well.