Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 13, 2025

This PR adds two useful utility scripts:

  1. bin/utils/resolve-texera-home.sh, automatically resolve TEXERA_HOME.
  2. bin/utils/texera-logging.sh, a colorful logging helper with Texera line header: Texera ▶.

To demonstrate how to use those two scripts, I have included an example script that uses the utility scripts above.

  • bin/fix-format.sh, a handy script to fix formats, can optionally choose which component to fix.

By default, it is recommended to execute scripts from root. For example, use bin/fix-format.sh to fix format. But all the scripts in this PR should also be working inside bin directory as well.

Copilot AI review requested due to automatic review settings October 13, 2025 07:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will any other part of the system use those scripts?
If not, why do we need a script to output TEXERA_HOME? It's more meaningful to have a script that sets TEXERA_HOME rather than outputting it.

If you have any future plans, you should explain them in the PR description. Those three scripts are not useful on their own.

@Yicong-Huang
Copy link
Contributor Author

Yicong-Huang commented Oct 15, 2025 via email

Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
So I think the main part of this PR is to add fix-format.sh, and the other two scripts are just helpers for it, but they can also be reused by other scripts.

@Yicong-Huang
Copy link
Contributor Author

Yicong-Huang commented Oct 15, 2025 via email

@aglinxinyuan
Copy link
Contributor

Thanks. I view it the other way: the main purpose is to introduce the two helper scripts. They are critical building blocks for other scripts. And fix-format.sh is just a demo of how to use the other two util scripts. fix-format.sh is just a syntax sugar of all linter commands consolidated into one handy script.

On Tue, Oct 14, 2025 at 6:47 PM Xinyuan Lin @.> wrote: @.* approved this pull request. LGTM! So I think the main part of this PR is to add fix-format.sh, and the other two scripts are just helpers for it, but they can also be reused by other scripts. — Reply to this email directly, view it on GitHub <#3890 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGPVNIGE2ZGUEYZD4GSTRL3XWRTRAVCNFSM6AAAAACJALJT2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMZYGA4DIOBVHA . You are receiving this because you were assigned.Message ID: @.***>

Ok. Can you explain that in the PR description? Having bullet points of 1.2.3 gave me the impression that they are at the same level and they are all the same type of helper script, but in fact, utils and fix-format are quite different.

@Yicong-Huang Yicong-Huang enabled auto-merge (squash) October 15, 2025 03:48
@Yicong-Huang Yicong-Huang disabled auto-merge October 15, 2025 03:49
@Yicong-Huang Yicong-Huang enabled auto-merge (squash) October 15, 2025 03:49
@Yicong-Huang Yicong-Huang merged commit f03947c into main Oct 15, 2025
12 checks passed
@Yicong-Huang Yicong-Huang deleted the feat/add-some-helper-scripts branch October 15, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants