fix(deployment): deduplicate SQL files under deployment by using symlinks
#3824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace duplicate texera_ddl.sql in Helm chart with symlinks to core SQL files - Create symlinks for all three SQL files: texera_lakefs.sql, iceberg_postgres_catalog.sql, and texera_ddl.sql - Update ConfigMap to execute SQL files in correct order - Maintains single source of truth in core/scripts/sql/ This eliminates duplication and ensures consistency across deployments. Fixes apache#3823 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bobbai00
changed the title
deployment by using symlinks
aglinxinyuan
requested changes
Oct 6, 2025
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
Please fix the test case by adding the other two DDL files to github-action-build.yml as well, since you changed the content of texera_ddl.sql.
github-actions
bot
added
ddl-change
aglinxinyuan
requested changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR eliminates the duplication of SQL DDL files between
core/scripts/sql/anddeployment/k8s/texera-helmchart/files/by replacing duplicate files with symlinks.Changes
texera_ddl.sqlin the Helm chart directory with symlinks to the core SQL filestexera_lakefs.sql→../../../../core/scripts/sql/texera_lakefs.sqliceberg_postgres_catalog.sql→../../../../core/scripts/sql/iceberg_postgres_catalog.sqltexera_ddl.sql→../../../../core/scripts/sql/texera_ddl.sqlBenefits
core/scripts/sql/Fixes #3823