Skip to content

Conversation

@mengw15
Copy link
Contributor

@mengw15 mengw15 commented Oct 1, 2025

PR #3794 attempted to bump torch from 2.4.1 to 2.8.0 under /core/amber, but ran into dependency conflicts.
This PR resolves those conflicts by:
Bumping torch 2.4.1 → 2.8.0
Bumping typing_extensions 4.9.0 → 4.10.0

Screenshot 2025-09-30 at 5 50 44 PM

dependabot bot and others added 4 commits September 30, 2025 22:07
Bumps [torch](https://github.com/pytorch/pytorch) from 2.4.1 to 2.8.0.
- [Release notes](https://github.com/pytorch/pytorch/releases)
- [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md)
- [Commits](pytorch/pytorch@v2.4.1...v2.8.0)

---
updated-dependencies:
- dependency-name: torch
  dependency-version: 2.8.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@mengw15 mengw15 marked this pull request as draft October 1, 2025 00:42
@mengw15 mengw15 changed the title chore(deps): bump torch from 2.4.1 to 2.8.0 and bump chore(deps): bump torch from 2.4.1 to 2.8.0 and bump typing_extensions from 4.9.0 to 4.10.0 Oct 1, 2025
@aglinxinyuan aglinxinyuan self-requested a review October 1, 2025 00:48
@aglinxinyuan aglinxinyuan changed the title chore(deps): bump torch from 2.4.1 to 2.8.0 and bump typing_extensions from 4.9.0 to 4.10.0 chore(deps): bump torch from 2.4.1 to 2.8.0 and typing_extensions from 4.9.0 to 4.10.0 Oct 1, 2025
@aglinxinyuan aglinxinyuan added dependencies Pull requests that update a dependency file python labels Oct 1, 2025
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aglinxinyuan aglinxinyuan marked this pull request as ready for review October 1, 2025 01:05
Copilot AI review requested due to automatic review settings October 1, 2025 01:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves dependency conflicts encountered in PR #3794 by updating PyTorch and typing_extensions to newer versions. The changes address compatibility issues that prevented the original torch upgrade.

  • Updates torch from 2.4.1 to 2.8.0 in operator requirements
  • Updates typing_extensions from 4.9.0 to 4.10.0 in core requirements

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/amber/requirements.txt Updates typing_extensions to 4.10.0 to resolve dependency conflicts
core/amber/operator-requirements.txt Updates torch to 2.8.0 as originally intended in PR #3794

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aglinxinyuan aglinxinyuan merged commit bc26017 into apache:main Oct 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants