fix: Correctly format workflow JSON when downloading from hub #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mengw15 Please review it. After that, ask @aglinxinyuan to review it. |
mengw15
reviewed
Sep 22, 2025
mengw15
reviewed
Sep 22, 2025
core/gui/src/app/dashboard/service/user/download/download.service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the incorrect JSON structure and formatting when downloading workflows from the hub's workflow list. Previously, the downloaded JSON had operators and other workflow properties incorrectly nested inside a
contentobject, which prevented the workflow from being re-uploaded and loaded properly. Workflow metadata was also removed from the download to keep the JSON consistent with workflow downloads using the "export workflow" button within an individual workflow canvas.Incorrect JSON Download Button:
Changes:
Edited the
downloadWorkflowfunction indownload.service.tsto correctly format the JSON file and bring workflow properties nested inside the content object up a level, as well as remove metadata from the download.Issues
Closes #3750