Move all conf files and readers to core/config
#3466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
added
config
Contributor
Author
|
@aglinxinyuan is the main reviewer. @shengquan-ni is the secondary reviewer. Please check the amber related changes. |
aglinxinyuan
approved these changes
Jun 11, 2025
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
LGTM! This PR is relatively straightforward. Although it touches many files, most of the changes are due to renaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #3458.
As titled, this PR moves all the conf files and their readers to the module
core/config. Specifically,core/config/src/main/resources: this folder contains all the conf files;core/config/src/main/scala/edu/uci/ics/amber/config: this package contains all the readers of amber-related configs;core/config/src/main/scala/edu/uci/ics/texera/config: this package contains all the readers of texera-micro-service-related configs;Future PR Plan
kubernetes.confwithcomputing-unit.confapplication.confinto a separate file, e.g.amber.conf