Add ViolinPlot Option to BoxPlot Operator #3356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have updated the registration name and image of the BoxPlot operator to BoxViolinPlot.
|
Contributor
Please directly modify the original description without adding any extra content. |
Contributor
|
Please add the dataset used for testing in the description of this PR. |
.../main/scala/edu/uci/ics/amber/operator/visualization/boxViolinPlot/BoxViolinPlotOpDesc.scala
Show resolved
Hide resolved
.../main/scala/edu/uci/ics/amber/operator/visualization/boxViolinPlot/BoxViolinPlotOpDesc.scala
Show resolved
Hide resolved
.../main/scala/edu/uci/ics/amber/operator/visualization/boxViolinPlot/BoxViolinPlotOpDesc.scala
Show resolved
Hide resolved
.../main/scala/edu/uci/ics/amber/operator/visualization/boxViolinPlot/BoxViolinPlotOpDesc.scala
Show resolved
Hide resolved
Contributor
Xiao-zhen-Liu
left a comment
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
I left a few more additional code comments. Please create anther PR to address them.
In addition, here are a few other comments on the PR title and description:
- The PR "adds Violin Plot Operator support to the existing Box Plot Operator." Since you are not creating a new operator, please change the PR title to something like "Add ViolinPlot Option to BoxPlot Operator".
- PR descriptions should be treated like formal documentations and should not have grammar issues. In your "Changes" section of the PR description, make sure your bullet points have consistent tense and format. For example, "Updated createPlotlyFigure() to support both plot types." and "Update the user-friendly operator name (Box Plot -> Box/Violin Plot)" differ both in tense and type (one has a comma while the other does not).
qzt168
changed the title
qzt168
added a commit
that referenced
this pull request
Apr 12, 2025
…lot operator (#3365) This PR fixes a previous PR (#3356), and includes the following updates: - Renamed variables for better clarity and consistency: - orientation → horizontalOrientation - violinplot → violinPlot - quartiletype → quartileType - Updated the Violin Plot checkbox description to clarify its behavior - Revised the operator description to explain that the violin plot overlays the box plot for better visualization - Modified the createPlotlyFigure() method: - Now supports `quartileType` when `box=True` in a violin plot - Removed `jitter=0` to allow data points to spread naturally instead of forming a straight line — this shows the distribution shape better <img width="1439" alt="image" src="https://github.com/user-attachments/assets/b8e96412-aadb-4b96-97fb-16eb6a67179b" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Changes:
In core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/visualization/boxViolinPlot/BoxViolinPlotOpDesc.scala:
violinplotwith a checkbox.violinplotis selected.In core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/LogicalOp.scala:
In core/gui/src/assets/operator_images/BoxViolinPlot.png:
Dataset for Test:
tips.csv