Refactor Navigation(Menu) Component #2239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aglinxinyuan
changed the title
aglinxinyuan
changed the title
aglinxinyuan
changed the title
aglinxinyuan
changed the title
aglinxinyuan
changed the title
Yicong-Huang
approved these changes
Dec 4, 2023
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM. Please make sure to rename not only the code, but also the comments, files, packages, etc.
core/new-gui/src/app/workspace/component/menu/menu.component.ts
Outdated
Show resolved
Hide resolved
core/new-gui/src/app/workspace/component/menu/menu.component.ts
Outdated
Show resolved
Hide resolved
kunwp1
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is the first PR of the resizeable Workspace: Refactor Navigation Component. In this PR: 1. Rename Navigation to Menu. 2. We relax the grid layout system to a normal flow layout 3. Clean up the CSS and HTML. 4. Make the buttons regular size. 5. Make the layout more compact. 6. Move the workflow timer to the right of the run button. 7. Move the Undo and Redo buttons to the Utilities button group. 8. Make the Utilities button group collapsible when the screen size is small. 9. Set the min-width of the workspace to 630px;  **Expanded Utilities buttons(Window is large enough):** <img width="1077" alt="Screenshot 2023-12-02 at 3 01 05 AM" src="https://github.com/Texera/texera/assets/11544314/85dd7993-4954-4b4c-bff7-4da51c5cb084"> **Collapsed Utilities buttons(Window is small enough):** <img width="765" alt="Screenshot 2023-12-02 at 2 56 46 AM" src="https://github.com/Texera/texera/assets/11544314/ad4ba3dd-870b-477d-a030-ccdb6ecee8f6"> **Hovered Utilities buttons:** <img width="766" alt="Screenshot 2023-12-02 at 2 55 01 AM" src="https://github.com/Texera/texera/assets/11544314/d29c00aa-0c73-46b6-8c3a-7dc273e14776">
Xiao-zhen-Liu
pushed a commit
that referenced
this pull request
Jan 16, 2024
This is the first PR of the resizeable Workspace: Refactor Navigation Component. In this PR: 1. Rename Navigation to Menu. 2. We relax the grid layout system to a normal flow layout 3. Clean up the CSS and HTML. 4. Make the buttons regular size. 5. Make the layout more compact. 6. Move the workflow timer to the right of the run button. 7. Move the Undo and Redo buttons to the Utilities button group. 8. Make the Utilities button group collapsible when the screen size is small. 9. Set the min-width of the workspace to 630px;  **Expanded Utilities buttons(Window is large enough):** <img width="1077" alt="Screenshot 2023-12-02 at 3 01 05 AM" src="https://github.com/Texera/texera/assets/11544314/85dd7993-4954-4b4c-bff7-4da51c5cb084"> **Collapsed Utilities buttons(Window is small enough):** <img width="765" alt="Screenshot 2023-12-02 at 2 56 46 AM" src="https://github.com/Texera/texera/assets/11544314/ad4ba3dd-870b-477d-a030-ccdb6ecee8f6"> **Hovered Utilities buttons:** <img width="766" alt="Screenshot 2023-12-02 at 2 55 01 AM" src="https://github.com/Texera/texera/assets/11544314/d29c00aa-0c73-46b6-8c3a-7dc273e14776">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of the resizeable Workspace: Refactor Navigation Component.
In this PR:
Expanded Utilities buttons(Window is large enough):
Collapsed Utilities buttons(Window is small enough):
Hovered Utilities buttons:
