build: Add python 3.8 to the build matrix #9827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9827 +/- ##
==========================================
+ Coverage 70.88% 71.02% +0.13%
==========================================
Files 585 585
Lines 30432 30615 +183
Branches 3152 3152
==========================================
+ Hits 21571 21743 +172
- Misses 8749 8760 +11
Partials 112 112
Continue to review full report at Codecov.
|
etr2460
force-pushed
the
etr2460--test-3.8
branch
from
a7bae0a to
55e2a7a
Compare
etr2460
force-pushed
the
etr2460--test-3.8
branch
from
55e2a7a to
0fa6184
Compare
etr2460
commented
May 17, 2020
| @@ -1150,7 +1150,7 @@ def test_feature_flag_serialization(self): | |||
| {"FOO": lambda x: 1, "super": "set"}, | |||
| default=utils.pessimistic_json_iso_dttm_ser, | |||
| ) | |||
| html = cgi.escape(encoded).replace("'", "'").replace('"', """) | |||
There was a problem hiding this comment.
deprecated, see https://docs.python.org/3.7/library/cgi.html#cgi.escape
etr2460
force-pushed
the
etr2460--test-3.8
branch
from
0fa6184 to
ddf61f9
Compare
john-bodley
changed the title
john-bodley
changed the title
etr2460
force-pushed
the
etr2460--test-3.8
branch
from
ddf61f9 to
637db79
Compare
craig-rueda
approved these changes
May 17, 2020
john-bodley
approved these changes
May 17, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Upgrades some deps to support 3.6 through 3.8 and removes a deprecated function.
Note that this does not guarantee support for all db engines, only support for postgres
TEST PLAN
CI
ADDITIONAL INFORMATION
to: @john-bodley @craig-rueda @villebro @bkyryliuk