Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling recording in Cypress tests #9535

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Disabling recording in Cypress tests #9535

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b278c38
Disabling recording in Cypress tests
craig-rueda Apr 14, 2020
2909c82
Removing --group --ci-build-id
craig-rueda Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/superset-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
REDIS_PORT: 16379
CI: github-actions
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
services:
postgres:
image: postgres:10-alpine
Expand Down Expand Up @@ -69,7 +68,7 @@ jobs:
cd ${{ github.workspace }}/superset-frontend/cypress-base/
npm run cypress -- run \
--browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \
--record --group "${{ env.CYPRESS_GROUP }}" \
--record false --group "${{ env.CYPRESS_GROUP }}" \
--ci-build-id ${{ github.event_name }}-${{ github.run_id }}

- name: Cypress run SQL Lab (with backend persist)
Expand All @@ -87,5 +86,5 @@ jobs:
cd ${{ github.workspace }}/superset-frontend/cypress-base/
npm run cypress -- run \
--browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \
--record --group "${{ env.CYPRESS_GROUP }}" \
--record false --group "${{ env.CYPRESS_GROUP }}" \
--ci-build-id ${{ github.event_name }}-${{ github.run_id }}