Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable beautiful json for dashboard metadata editor #9482

Closed
wants to merge 1 commit into from

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 7, 2020

Try #9474 in a new branch to trigger CI.

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Reformat JSON strings in the dashboard metadata modal input so it's easier to edit.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Snip20200405_58

After

Snip20200405_57

TEST PLAN

  1. Pick a random dashboard with filters
  2. Edit metadata via "Edit dashboard" -> "" -> "Edit dashboard properties" -> "Advanced".

The JSON string in the code editor should be formatted.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@graceguo-supercat @etr2460

@nytai
Copy link
Member

nytai commented Apr 7, 2020

welp.. looks like the job was received: https://travis-ci.org/github/apache/incubator-superset/builds/671939629?utm_medium=notification&utm_source=github_status but it hasn't notified github

@ktmud ktmud mentioned this pull request Apr 7, 2020
@ktmud ktmud force-pushed the dashboard-meta branch 3 times, most recently from e2448ca to 747bc3a Compare April 9, 2020 00:37
@codecov-io
Copy link

Codecov Report

Merging #9482 into master will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9482      +/-   ##
==========================================
- Coverage   58.76%   58.75%   -0.02%     
==========================================
  Files         385      385              
  Lines       12237    12241       +4     
  Branches     3020     3020              
==========================================
+ Hits         7191     7192       +1     
- Misses       4862     4865       +3     
  Partials      184      184              
Impacted Files Coverage Δ
...ntend/src/dashboard/components/PropertiesModal.jsx 46.83% <20.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd85696...747bc3a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants