-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix CORS section in installation #8958
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8958 +/- ##
=========================================
- Coverage 58.97% 58.68% -0.3%
=========================================
Files 359 362 +3
Lines 11333 11415 +82
Branches 2787 2801 +14
=========================================
+ Hits 6684 6699 +15
- Misses 4471 4538 +67
Partials 178 178
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc change seems fine. I'm a bit confused why you'd need to separately install another dep instead of it being included in requirements or requirements-extra, but i don't have the historical context
CORS is optional for Superset app. it's contributed by community: |
What is the purpose of this change? If the purpose is to describe the process when not installing Superset via |
docs/installation.rst
Outdated
|
||
pip install -U flask-cors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's slightly better to recommend pip install apache-superset[cors]
, that way it will reference the version range or pinned version specified in setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
c2661ff
to
4e9b34d
Compare
CATEGORY
Choose one
SUMMARY
Fix the extra CORS Dependency in Superset installation step.
TEST PLAN
https://superset.incubator.apache.org/installation.html#cors
ADDITIONAL INFORMATION
REVIEWERS
@michellethomas @mistercrunch @etr2460