[dashboards] New, export api #8941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8941 +/- ##
==========================================
+ Coverage 58.97% 58.98% +0.01%
==========================================
Files 359 359
Lines 11333 11336 +3
Branches 2787 2788 +1
==========================================
+ Hits 6684 6687 +3
Misses 4471 4471
Partials 178 178
Continue to review full report at Codecov.
|
nytai
approved these changes
Jan 9, 2020
dpgaspar
commented
Jan 10, 2020
suddjian
reviewed
Jan 13, 2020
| @@ -44,8 +44,7 @@ class DashboardModelView( | |||
| datamodel = SQLAInterface(models.Dashboard) | |||
|
|
|||
| @action("mulexport", __("Export"), __("Export dashboards?"), "fa-database") | |||
| @staticmethod | |||
| def mulexport(items): | |||
| def mulexport(self, items): # pylint: disable=no-self-use | |||
There was a problem hiding this comment.
What's the reasoning behind this change?
There was a problem hiding this comment.
It's related with this already merged PR: #8942
the @action decorator creates a methods attribute on the method, this is defeated by making the method static
| """ | ||
| self.login(username="admin") | ||
| argument = [1, 2] | ||
| uri = f"api/v1/dashboard/export/?q={prison.dumps(argument)}" |
There was a problem hiding this comment.
So the final URL here looks like api/v1/dashboard/export/?q=!(1,2)?
robdiciuccio
approved these changes
Jan 15, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Implements a dashboard export API endpoint. To have the exact same functionality on the API and on MVC
ModelView. This will be used by the new React view for dashboards.Added enhanced security for the export, applying the filter that's applied for list and get
ADDITIONAL INFORMATION
REVIEWERS
@nytai