Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running of tests in tests/db_engine_specs #8902

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Enable running of tests in tests/db_engine_specs #8902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
977842a
Enable running of tests in tests/db_engine_specs
robdiciuccio Dec 30, 2019
7914aa8
Resolve application context errors
robdiciuccio Dec 30, 2019
dd4af7a
Refactor and add tests for pyodbc.Row conversion
robdiciuccio Dec 30, 2019
f5ac6bf
Appease isort, regardless of isort:skip
robdiciuccio Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve application context errors
  • Loading branch information
@robdiciuccio
robdiciuccio committed Dec 30, 2019
commit 7914aa848e0be18ee80207dfc84a0584fa085801
2 changes: 2 additions & 0 deletions tests/db_engine_specs/athena_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from tests.test_app import app # isort:skip

from superset.db_engine_specs.athena import AthenaEngineSpec
from tests.db_engine_specs.base_tests import DbEngineSpecTestCase

Expand Down
2 changes: 1 addition & 1 deletion tests/db_engine_specs/base_engine_spec_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# under the License.
from unittest import mock

from superset import app
from tests.test_app import app # isort:skip
from superset.db_engine_specs import engines
from superset.db_engine_specs.base import BaseEngineSpec, builtin_time_grains
from superset.db_engine_specs.sqlite import SqliteEngineSpec
Expand Down
1 change: 1 addition & 0 deletions tests/db_engine_specs/base_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# under the License.
from datetime import datetime

from tests.test_app import app # isort:skip
from superset.db_engine_specs.mysql import MySQLEngineSpec
from superset.models.core import Database
from tests.base_tests import SupersetTestCase
Expand Down