Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FAB to 2.2.0 #8517

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Bump FAB to 2.2.0 #8517

merged 1 commit into from
Nov 12, 2019

Conversation

nytai
Copy link
Member

@nytai nytai commented Nov 6, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Change log since 2.1.13:

Improvements and Bug fixes on 2.2.0

Fix, dpgaspar/Flask-AppBuilder#1157 Improve API get menu data performance
Fix, dpgaspar/Flask-AppBuilder#1143 [mvc] pagination
Fix, dpgaspar/Flask-AppBuilder#1147 [babel] crash with empty LANGUAGES config key
New, dpgaspar/Flask-AppBuilder#1116 Expose menu data as serializable objects
Fix, dpgaspar/Flask-AppBuilder#1127 MSSQL issue with pagination
Fix, dpgaspar/Flask-AppBuilder#1132 Add autofocus for login screen (dpgaspar/Flask-AppBuilder#1132)
Fix, dpgaspar/Flask-AppBuilder#1125 Support absence of the public role (dpgaspar/Flask-AppBuilder#1125)
New, dpgaspar/Flask-AppBuilder#1124 hide tabs when only 'Detail' (no related_views)
Fix, dpgaspar/Flask-AppBuilder#1119 ldap: safely retrieve error object when loggin exception

TEST PLAN

  • CI tests pass
  • All example dashboards render
  • sql lab works
  • explore view works

ADDITIONAL INFORMATION

REVIEWERS

@nytai nytai changed the title fab 2.2.0 Bump FAB to 2.2.0 Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #8517 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8517      +/-   ##
==========================================
- Coverage   66.68%   66.51%   -0.17%     
==========================================
  Files         449      449              
  Lines       22684    22687       +3     
  Branches     2366     2366              
==========================================
- Hits        15126    15091      -35     
- Misses       7420     7458      +38     
  Partials      138      138
Impacted Files Coverage Δ
superset/db_engine_specs/mysql.py 40.74% <0%> (-51.86%) ⬇️
superset/dataframe.py 92.91% <0%> (-1.58%) ⬇️
superset/views/utils.py 90.09% <0%> (-0.66%) ⬇️
superset/models/core.py 82.35% <0%> (-0.58%) ⬇️
superset/views/core.py 71.75% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78e59b...b9183b8. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you include a test plan here? How did you verify that upgrading the dep worked?

@nytai
Copy link
Member Author

nytai commented Nov 7, 2019

@etr2460 updated pr description with my basic smoke test. Let me know if there's anything else I should take into account

@nytai nytai requested a review from etr2460 November 7, 2019 19:17
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding the test plan!

@etr2460 etr2460 merged commit 6bce4f9 into apache:master Nov 12, 2019
@willbarrett willbarrett deleted the tai/bump-fab branch November 12, 2019 17:39
graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants