Fix for incorrect attaching of raw data files to email schedules chart report #8339
Conversation
superset/tasks/schedules.py
Outdated
| data = {__("%(name)s.csv", name=slc.slice_name): response.content} | ||
| csv_content = "" | ||
| for r in content: | ||
| csv_content += str(r, 'utf-8') |
There was a problem hiding this comment.
Indentation here needs to be four spaces, not two.
|
You still need to run black on the modified files. Furthermore, the tests are failing because the CSV request mock in the test case conforms to the |
README.md
Outdated
| @@ -214,3 +214,4 @@ the world know they are using Superset. Join our growing community! | |||
| 1. [Zalando](https://www.zalando.com) | |||
| 1. [Zalora](https://www.zalora.com) | |||
| 1. [TME QQMUSIC/WESING](https://www.tencentmusic.com/) | |||
| 1. [Facemetrics](https://facemetrics.io/) | |||
|
@ngritsuk can I help you finalize this PR somehow? This is a regression that I would be very happy to see getting merged soon. |
|
@villebro Probably I'll have time to deal with tests at the end of this week. I'll be happy if you help me with them. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
CATEGORY
Choose one
SUMMARY
Schedule Email Reports fails in a case of attached data files. Present fix resolve this regression from the removal of the dependency
requestTEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@villebro