Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deck.gl sample charts with js #7749

Merged
merged 3 commits into from
Jun 23, 2019
Merged

Fix deck.gl sample charts with js #7749

merged 3 commits into from
Jun 23, 2019

Conversation

villebro
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)

SUMMARY

The js code in the deck.gl examples wasn't working correctly.

BEFORE

Screenshot 2019-06-21 at 16 04 34

Screenshot 2019-06-21 at 16 04 41

AFTER

Screenshot 2019-06-21 at 16 07 23

Screenshot 2019-06-21 at 16 07 29

TEST PLAN

Tested locally

REVIEWERS

@mistercrunch

@codecov-io
Copy link

Codecov Report

Merging #7749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7749   +/-   ##
=======================================
  Coverage   65.78%   65.78%           
=======================================
  Files         459      459           
  Lines       21924    21924           
  Branches     2411     2411           
=======================================
  Hits        14423    14423           
  Misses       7380     7380           
  Partials      121      121
Impacted Files Coverage Δ
superset/data/deck.py 11.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abcdcc...b15c553. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, nice catch!

@mistercrunch mistercrunch merged commit 1df4fa2 into apache:master Jun 23, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants