Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest from apache:lyft-develop #7543

Closed
wants to merge 59 commits into from

Conversation

DiggidyDave
Copy link
Contributor

No description provided.

mistercrunch and others added 30 commits April 23, 2019 15:51
(cherry picked from commit 89ba06d)
(cherry picked from commit 1dfc8f2)
(cherry picked from commit 7aefa26)
(cherry picked from commit e546132)
(cherry picked from commit 3bf49c4)
(cherry picked from commit 9b3420c8ef51739206282514ca4a69fb01a2066f)
(cherry picked from commit 2df0fb8d286616cd4d5b9f582d337c726edd1d7a)
(cherry picked from commit 2829ead)
(cherry picked from commit ac9dbef)
(cherry picked from commit 0c32389)
(cherry picked from commit 5aceb0a)
(cherry picked from commit b7ca416)
(cherry picked from commit 38732a8)
(cherry picked from commit 0008256)
(cherry picked from commit d9e5be7)
(cherry picked from commit d23bfa0)

(cherry picked from commit 7fdd3e8)
(cherry picked from commit 914029d)
(cherry picked from commit 0c35cd9)
(cherry picked from commit fe6ea59)
(cherry picked from commit ec2568e)
(cherry picked from commit 22edad8)
(cherry picked from commit 8464ffc)
(cherry picked from commit 4f58845)
(cherry picked from commit d697ae9)
(cherry picked from commit 7bd6b48)
(cherry picked from commit 8ded83f)
(cherry picked from commit 1524510)
(cherry picked from commit 0dbaaf9)
(cherry picked from commit 046736c)
(cherry picked from commit 49a3398)
(cherry picked from commit 9c10547)
(cherry picked from commit adaf91e)
(cherry picked from commit a21bf84)
(cherry picked from commit f3fc08a)
(cherry picked from commit 600d580)
(cherry picked from commit 1fe113a)
(cherry picked from commit f56b291)
(cherry picked from commit 66e8955)
(cherry picked from commit 112a2b7)
(cherry picked from commit 8cddc63)
(cherry picked from commit 896e1cf)
(cherry picked from commit 5b71a43)
(cherry picked from commit 03860f8)
(cherry picked from commit a2b2852)
(cherry picked from commit 27e2709)
(cherry picked from commit e9469ed)
(cherry picked from commit 040ce96)
(cherry picked from commit c0bf1d2)
(cherry picked from commit 8b93ead)
(cherry picked from commit 50fb6b7)
(cherry picked from commit 31e8345)
(cherry picked from commit 56bb3b9)
(cherry picked from commit d575ccb)
(cherry picked from commit 46487c5)
(cherry picked from commit 18e944a382a5cf867020b5d31e90144aa7a3c07e)
(cherry picked from commit a8ac3fb)
(cherry picked from commit 55b7eb6)

Rebase

Fix tag endpoint

(cherry picked from commit d714792)
(cherry picked from commit 8181c54)
(cherry picked from commit e82c615)
(cherry picked from commit 8cd80a2)
(cherry picked from commit 2ba0dee)
(cherry picked from commit e3a5621)
(cherry picked from commit 2bb73e4)
(cherry picked from commit e63fdf6)
(cherry picked from commit dc5a95c)
(cherry picked from commit b643ff0)
Kepler.gl is an amazing geospatial React application. It offers a very
well designed user interface to compose geo layers and slice and dice
geospatial data.

As it turns out, Kepler is designed to be embedded as part of React
apps. It took me only a few hours to get to a working prototype.

Next steps:
* allow to save the state, without the data
* restore the state, and merge with the new data
* tweak styles, make a light style that looks decent within Superste,
  Kepler uses stylable components, so that should be somewhat
  straigthforward

(cherry picked from commit 43ed9a6)
(cherry picked from commit 595832a)
(cherry picked from commit 1fa1d05)
(cherry picked from commit 791776e)
(cherry picked from commit 568afd4)
(cherry picked from commit 472564b)
(cherry picked from commit 65282a6)
(cherry picked from commit 692794f)
* filter out all nan series (apache#7313)

* improve not rich tooltip (apache#7345)

* Create issue_label_bot.yaml (apache#7341)

* fix: do not save colors without a color scheme (apache#7347)

* [wtforms] Strip leading/trailing whitespace (apache#7084)

* [schema] Updating the datasources schema (apache#5451)

* limit tables/views returned if schema is not provided (apache#7358)

* limit tables/views returned if schema is not provided

* fix typo

* improve code performance

* handle the case when table name or view name does not present a schema

* Add type anno (apache#7342)

* Updated local dev instructions to include missing step

* First pass at type annotations

* [schema] Updating the base column schema (apache#5452)

* Update 937d04c16b64_update_datasources.py (apache#7361)

* Feature flag for client cache (apache#7348)

* Feature flag for client cache

* Fix integration test

* Revert "Fix integration test"

This reverts commit 58434ab.

* Feature flag for client cache

* Fix integration tests

* Add feature flag to config.py

* Add another feature check

* Fix more integration tests

* Fix raw HTML in SliceAdder (apache#7338)

* remove backendSync.json (apache#7331)

* [bubbles] issue when using duplicated metrics (apache#7087)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359)

* SUPERSET-8: Update text in docs copyright footer (apache#7360)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04

* SUPERSET-8: Extra text in docs copyright footer

* [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371)

*  Store last selected dashboard in sessionStorage (apache#7181)

* Store last selected dashboard in sessionStorage

* Fix tests

* [schema] Updating the base metric schema (apache#5453)

* Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365)
start sp8: merge lyft-develop to lyft-master for staging
* feat: see Presto row and array data types

* fix: address PR comments

* fix: lint and build issues

* fix: add types
update package-lock.json, since our deps may be different
…ase-sp8) (apache#7415)

* add stronger type hints where possible

* fix: lint issues and add select_star func in Hive

* add missing pkg init

* fix: build issues

* fix: pylint issues

* fix: use logging instead of print
merge from apache/lyft-release-sp8
Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (apache#7415)
* feat: view presto row objects in data grid

* fix: address feedback

* fix: spacing
* Lightweight pipelines POC

* Add docs

* Minor fixes

* Remove Lyft URL

* Use enum

* Minor fix

* Fix unit tests

* Mark props as required
feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)
feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)
Merge latest from lyft-release-sp8
 Merge latest from lyft-release-sp8
DiggidyDave and others added 26 commits May 3, 2019 16:36
Add `validate_sql_json` endpoint for checking that a given sql query
Add `validate_sql_json` endpoint for checking that a given sql query
* [WIP] Live query validation, where supported

This builds on apache#7422 to build check-as-you-type sql
query validation in Sql Lab. This closes apache#6707 too.

It adds a (debounced) call to the validate_sql_json
API endpoint with the querytext, and on Lyft infra is
able to return feedback to the user (end to end) in
$TBD seconds.

At present feedback is provided only through the
"annotations" mechanism build in to ACE, although
I'd be open to adding full text elsewhere on the
page if there's interest.

* fix: Unbreak lints and tests
Merge branch 'mergeSQLUIDevelop' into lyft-master
 feat: Live query validation in the SQL Lab UI
 feat: Live query validation in the SQL Lab UI
Merge tip of lyft-release-sp8
Merge lyft-develop to lyft-master
* fix: alter sql columns to long text

* fix: handle dbs that don't require text length

* fix: 1GB limit

* fix: only handle mysql

* Empty Commit
* filter out all nan series (apache#7313)

* improve not rich tooltip (apache#7345)

* Create issue_label_bot.yaml (apache#7341)

* fix: do not save colors without a color scheme (apache#7347)

* [wtforms] Strip leading/trailing whitespace (apache#7084)

* [schema] Updating the datasources schema (apache#5451)

* limit tables/views returned if schema is not provided (apache#7358)

* limit tables/views returned if schema is not provided

* fix typo

* improve code performance

* handle the case when table name or view name does not present a schema

* Add type anno (apache#7342)

* Updated local dev instructions to include missing step

* First pass at type annotations

* [schema] Updating the base column schema (apache#5452)

* Update 937d04c16b64_update_datasources.py (apache#7361)

* Feature flag for client cache (apache#7348)

* Feature flag for client cache

* Fix integration test

* Revert "Fix integration test"

This reverts commit 58434ab.

* Feature flag for client cache

* Fix integration tests

* Add feature flag to config.py

* Add another feature check

* Fix more integration tests

* Fix raw HTML in SliceAdder (apache#7338)

* remove backendSync.json (apache#7331)

* [bubbles] issue when using duplicated metrics (apache#7087)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359)

* SUPERSET-8: Update text in docs copyright footer (apache#7360)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04

* SUPERSET-8: Extra text in docs copyright footer

* [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371)

*  Store last selected dashboard in sessionStorage (apache#7181)

* Store last selected dashboard in sessionStorage

* Fix tests

* [schema] Updating the base metric schema (apache#5453)

* Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365)

* Added living goods as among the users of Superset (apache#7407)

* Added living goods as among the users of Superset

Living Goods is a non profit organisation with operation in africa and the middle east. We work in community health use data heavily on day to day. Superset is our platform of choice for dashboards.

* Update README.md

* [dashboard] allow user re-order top-level tabs (apache#7390)

* [SQL Lab] Increase timeout threshold for offline check (apache#7411)

* Bump FAB to 2.0.0 (apache#7323)

* Bump FAB to 2.0.0

* [tests] whitelist SecurityApi login and refresh endpoints

* [style] Fix, C812 missing trailing commas

* [security] Remove SUPERSET_UPDATE_PERMS flag

Registering sources needs to be performed after the views are
initialized on UPDATE_PERMS=False configuration

* [docs] New, FAB_UPDATE_PERMS and flask fab cli

* [docs] Fix, db upgrade needs to come first, create-admin needs a db

* [cli] New, superset init bootstraps all permissions for FAB and Superset

* [style] Fix, flakes

* [annotations] Improves UX on annotation validation, start_dttm, end_dttm (apache#7326)

* Setting renderTrigger on label_colors (apache#7410)

* Refactor out controlUtils.js module + unit tests (apache#7350)

* [WiP]refactor out a controlUtils.js file

* unit tests

* add missing license

* Addressing comments

* feature: see Presto row and array data types (apache#7413)

* Merge lastest from master into lyft-release-sp8 (apache#7405)

* filter out all nan series (apache#7313)

* improve not rich tooltip (apache#7345)

* Create issue_label_bot.yaml (apache#7341)

* fix: do not save colors without a color scheme (apache#7347)

* [wtforms] Strip leading/trailing whitespace (apache#7084)

* [schema] Updating the datasources schema (apache#5451)

* limit tables/views returned if schema is not provided (apache#7358)

* limit tables/views returned if schema is not provided

* fix typo

* improve code performance

* handle the case when table name or view name does not present a schema

* Add type anno (apache#7342)

* Updated local dev instructions to include missing step

* First pass at type annotations

* [schema] Updating the base column schema (apache#5452)

* Update 937d04c16b64_update_datasources.py (apache#7361)

* Feature flag for client cache (apache#7348)

* Feature flag for client cache

* Fix integration test

* Revert "Fix integration test"

This reverts commit 58434ab.

* Feature flag for client cache

* Fix integration tests

* Add feature flag to config.py

* Add another feature check

* Fix more integration tests

* Fix raw HTML in SliceAdder (apache#7338)

* remove backendSync.json (apache#7331)

* [bubbles] issue when using duplicated metrics (apache#7087)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359)

* SUPERSET-8: Update text in docs copyright footer (apache#7360)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04

* SUPERSET-8: Extra text in docs copyright footer

* [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371)

*  Store last selected dashboard in sessionStorage (apache#7181)

* Store last selected dashboard in sessionStorage

* Fix tests

* [schema] Updating the base metric schema (apache#5453)

* Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365)

* feat: see Presto row and array data types (apache#7391)

* feat: see Presto row and array data types

* fix: address PR comments

* fix: lint and build issues

* fix: add types

* add stronger type hints where possible

* fix: lint issues and add select_star func in Hive

* add missing pkg init

* fix: build issues

* fix: pylint issues

* fix: use logging instead of print

* Removed --console-log and superset runserver (apache#7421)

* Fixes dashboard export button missing download and apache#7353 (apache#7427)

* Added additional German translations to string file (apache#6604)

* Added additional German translations to string file

Updates to German translation files as per directions

* Removed messages.json

* [fix] Fixing SQL parsing issue (apache#7374)

* add chinese translate (apache#7402)

* Quick fix to address deadlock issue (apache#7434)

* feat: view presto row objects in data grid (apache#7445)

* Merge lastest from master into lyft-release-sp8 (apache#7405)

* filter out all nan series (apache#7313)

* improve not rich tooltip (apache#7345)

* Create issue_label_bot.yaml (apache#7341)

* fix: do not save colors without a color scheme (apache#7347)

* [wtforms] Strip leading/trailing whitespace (apache#7084)

* [schema] Updating the datasources schema (apache#5451)

* limit tables/views returned if schema is not provided (apache#7358)

* limit tables/views returned if schema is not provided

* fix typo

* improve code performance

* handle the case when table name or view name does not present a schema

* Add type anno (apache#7342)

* Updated local dev instructions to include missing step

* First pass at type annotations

* [schema] Updating the base column schema (apache#5452)

* Update 937d04c16b64_update_datasources.py (apache#7361)

* Feature flag for client cache (apache#7348)

* Feature flag for client cache

* Fix integration test

* Revert "Fix integration test"

This reverts commit 58434ab.

* Feature flag for client cache

* Fix integration tests

* Add feature flag to config.py

* Add another feature check

* Fix more integration tests

* Fix raw HTML in SliceAdder (apache#7338)

* remove backendSync.json (apache#7331)

* [bubbles] issue when using duplicated metrics (apache#7087)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359)

* SUPERSET-8: Update text in docs copyright footer (apache#7360)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04

* SUPERSET-8: Extra text in docs copyright footer

* [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371)

*  Store last selected dashboard in sessionStorage (apache#7181)

* Store last selected dashboard in sessionStorage

* Fix tests

* [schema] Updating the base metric schema (apache#5453)

* Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365)

* feat: see Presto row and array data types (apache#7391)

* feat: see Presto row and array data types

* fix: address PR comments

* fix: lint and build issues

* fix: add types

* Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (apache#7415)

* add stronger type hints where possible

* fix: lint issues and add select_star func in Hive

* add missing pkg init

* fix: build issues

* fix: pylint issues

* fix: use logging instead of print

* feat: view presto row objects in data grid

* fix: address feedback

* fix: spacing

* feat: Scheduling queries from SQL Lab (apache#7416) (apache#7446)

* Merge lastest from master into lyft-release-sp8 (apache#7405)

* filter out all nan series (apache#7313)

* improve not rich tooltip (apache#7345)

* Create issue_label_bot.yaml (apache#7341)

* fix: do not save colors without a color scheme (apache#7347)

* [wtforms] Strip leading/trailing whitespace (apache#7084)

* [schema] Updating the datasources schema (apache#5451)

* limit tables/views returned if schema is not provided (apache#7358)

* limit tables/views returned if schema is not provided

* fix typo

* improve code performance

* handle the case when table name or view name does not present a schema

* Add type anno (apache#7342)

* Updated local dev instructions to include missing step

* First pass at type annotations

* [schema] Updating the base column schema (apache#5452)

* Update 937d04c16b64_update_datasources.py (apache#7361)

* Feature flag for client cache (apache#7348)

* Feature flag for client cache

* Fix integration test

* Revert "Fix integration test"

This reverts commit 58434ab.

* Feature flag for client cache

* Fix integration tests

* Add feature flag to config.py

* Add another feature check

* Fix more integration tests

* Fix raw HTML in SliceAdder (apache#7338)

* remove backendSync.json (apache#7331)

* [bubbles] issue when using duplicated metrics (apache#7087)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359)

* SUPERSET-8: Update text in docs copyright footer (apache#7360)

* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04

* SUPERSET-8: Extra text in docs copyright footer

* [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371)

*  Store last selected dashboard in sessionStorage (apache#7181)

* Store last selected dashboard in sessionStorage

* Fix tests

* [schema] Updating the base metric schema (apache#5453)

* Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365)

* feat: see Presto row and array data types (apache#7391)

* feat: see Presto row and array data types

* fix: address PR comments

* fix: lint and build issues

* fix: add types

* Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (apache#7415)

* add stronger type hints where possible

* fix: lint issues and add select_star func in Hive

* add missing pkg init

* fix: build issues

* fix: pylint issues

* fix: use logging instead of print

* feat: view presto row objects in data grid

* fix: address feedback

* fix: spacing

* Workaround for no results returned (apache#7442)

* feat: view presto row objects in data grid (apache#7436)

* feat: view presto row objects in data grid

* fix: address feedback

* fix: spacing

* feat: Scheduling queries from SQL Lab (apache#7416)

* Lightweight pipelines POC

* Add docs

* Minor fixes

* Remove Lyft URL

* Use enum

* Minor fix

* Fix unit tests

* Mark props as required

* feat: Add `validate_sql_json` endpoint for checking that a given sql query is valid for the chosen database (apache#7422) (apache#7462)

merge from lyft-release-sp8 to master

* Adds missing metric sum__SP_RUR_TOTL (apache#7452)

* Late import for optional lib pyhive (apache#7471)

* Late import for optional lib pyhive

* fix

* fix: calendar heatmap examples (apache#7375)

Fixing a set of examples that trip on ValueError vs TypeError

* bugfix: Improve support for special characters in schema and table names (apache#7297)

* Bugfix to SQL Lab to support tables and schemas with characters that require quoting

* Remove debugging prints

* Add uri encoding to secondary tables call

* Quote schema names for presto

* Quote selected_schema on Snowflake, MySQL and Hive

* Remove redundant parens

* Add python unit tests

* Add js unit test

* Fix flake8 linting error

* [dashboard] After update filter, trigger new queries when charts are visible (apache#7233)

* trigger query when chart is visible

* add integration test

* fix: alter sql columns to long text apache#7463 (apache#7476)

Merge lyft-release-sp8@7bfe7bc to master

* Refactor ConsoleLog (apache#7428)

* Revised Chinese translation (apache#7464)

* add chinese translate

* edit chinese translation

* druid connector: avoid using 'dimensions' for scan queries (apache#7377)

After the following PyDruid change (contained in version 0.5.2)
the Superset Histogram charts rendered with Druid data are
broken:

druid-io/pydruid@0a59a70

Bump the pydruid requirements accordingly in setup.py

Issue: apache#7368
Merge latest lyft-release-sp8, with latest from apache:master
)

* [WIP] Live query validation, where supported

This builds on apache#7422 to build check-as-you-type sql
query validation in Sql Lab. This closes apache#6707 too.

It adds a (debounced) call to the validate_sql_json
API endpoint with the querytext, and on Lyft infra is
able to return feedback to the user (end to end) in
$TBD seconds.

At present feedback is provided only through the
"annotations" mechanism build in to ACE, although
I'd be open to adding full text elsewhere on the
page if there's interest.

* fix: Unbreak lints and tests
…#7517)

This change makes the query progress bar only show
whole number percentage changes, instead of numbers
like 12.13168276%.
* Validate start/end when scheduling queries

* Use chrono instead of Sugar
* Show scheduled queries

* Remove column

* Secure views

* Add import

* Fix unit tests

* Reuse existing db connection from view

* Remove unnecessary import
@request-info
Copy link

request-info bot commented May 17, 2019

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need:more-info Requires more information from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants