-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: propagate color mapping from dashboard to charts #7289
Conversation
Codecov Report
@@ Coverage Diff @@
## lyftga #7289 +/- ##
==========================================
- Coverage 64.58% 64.57% -0.02%
==========================================
Files 425 426 +1
Lines 20884 20898 +14
Branches 2297 2297
==========================================
+ Hits 13488 13494 +6
- Misses 7270 7278 +8
Partials 126 126
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## lyftga #7289 +/- ##
==========================================
- Coverage 64.58% 64.57% -0.02%
==========================================
Files 425 426 +1
Lines 20884 20900 +16
Branches 2297 2299 +2
==========================================
+ Hits 13488 13496 +8
- Misses 7270 7278 +8
Partials 126 126
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dear @khtruong , do you know why color mapping fails when charts are rendered in Standalone mode? Would you mind helping fixing this issue? |
CATEGORY
Choose one
SUMMARY
If a dashboard has a color mapping saved and the user explores a chart from the dashboard, the coloring may look different. This is because we would propagate the color scheme but not the color mapping to the chart. This change fixes this issue. The PR also sets it up for color consistency in charts and the ability to change an individual color mapping in the future.
TEST PLAN
Tested manually
ADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat @kristw @williaster @betodealmeida @xtinec @DiggidyDave