Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partition query in Presto #7250

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix partition query in Presto #7250

merged 1 commit into from
Apr 9, 2019

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Apr 9, 2019

SUMMARY

Our Presto cluster doesn't support SHOW PARTITIONS. Reading the Presto docs, it's unclear to me if Presto supports this at all (cc: @nishantrayan). I changed the query that loads partitions to use the table_name$partitions hidden table instead.

TEST PLAN

SQL Lab is now able to load metadata correctly.

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[X] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec @datability-io @khtruong @nishantrayan

@betodealmeida betodealmeida requested review from mistercrunch and removed request for mistercrunch April 9, 2019 06:27
@betodealmeida betodealmeida added !deprecated-label:bug Deprecated label - Use #bug instead .database lyft Related to Lyft labels Apr 9, 2019
@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #7250 into lyftga will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           lyftga    #7250   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files         425      425           
  Lines       20861    20861           
  Branches     2280     2280           
=======================================
  Hits        13463    13463           
  Misses       7272     7272           
  Partials      126      126
Impacted Files Coverage Δ
superset/db_engine_specs.py 57.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ef41f...99dfacf. Read the comment docs.

@xtinec xtinec merged commit 821860e into apache:lyftga Apr 9, 2019
@hustwolf
Copy link

nice, i have the same problem, and i want to fix it ,but you already did

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:bug Deprecated label - Use #bug instead lyft Related to Lyft 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants