Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spinning in Welcome page #7247

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix spinning in Welcome page #7247

merged 1 commit into from
Apr 8, 2019

Conversation

betodealmeida
Copy link
Member

SUMMARY

The SavedQuery model has a url attribute that is a method, not a property. This causes requests to tagview/tagged_objects to fail.

TEST PLAN

Welcome page now loads correctly when user had saved queries.

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[x] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec @datability-io @khtruong

@Alagappan
Copy link
Contributor

👍

1 similar comment
@khtruong
Copy link
Contributor

khtruong commented Apr 8, 2019

+1

@codecov-io
Copy link

Codecov Report

Merging #7247 into lyftga will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           lyftga    #7247   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files         425      425           
  Lines       20861    20861           
  Branches     2280     2280           
=======================================
  Hits        13463    13463           
  Misses       7272     7272           
  Partials      126      126
Impacted Files Coverage Δ
superset/views/tags.py 42.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7cc01...31f8f21. Read the comment docs.

@betodealmeida betodealmeida merged commit 23ef41f into apache:lyftga Apr 8, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants