[revert] Revert #5445 #7095
Closed
[revert] Revert #5445 #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--revert-5445
branch
from
ea6440d
to
66eee14
Compare
Codecov Report
@@ Coverage Diff @@
## master #7095 +/- ##
==========================================
- Coverage 64.57% 64.56% -0.01%
==========================================
Files 422 422
Lines 20576 20574 -2
Branches 2251 2251
==========================================
- Hits 13286 13284 -2
Misses 7168 7168
Partials 122 122
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #5445 due to the fallout related to potentially ill-defined metadata. As discussed here the collective decision was to revert the logic (which will be cherry-picked into v0.31) and re-remedy the entire problem prior to the v0.32 branch cut.
Note this PR "reverts" in the sense of it creates a new database migration to rollback the state of the database to something representative prior to #5445.
to: @graceguo-supercat @michellethomas @mistercrunch @xtinec