Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FAB to 1.12.5 #7085

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Bump FAB to 1.12.5 #7085

merged 3 commits into from
Mar 22, 2019

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Mar 21, 2019

Changes since 1.12.3:

Improvements and Bug fixes on 1.12.5
Fix, #928 Copy role modal not showing
Improvements and Bug fixes on 1.12.4
Fix, #911 fabmanager missing session rollback() when user add fails
Fix, #910 Next page on OAuth

https://github.com/dpgaspar/Flask-AppBuilder/blob/master/docs/versions.rst

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #7085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7085   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files         422      422           
  Lines       20566    20566           
  Branches     2250     2250           
=======================================
  Hits        13257    13257           
  Misses       7182     7182           
  Partials      127      127
Impacted Files Coverage Δ
...uperset/assets/src/SqlLab/components/SouthPane.jsx 84.84% <0%> (ø) ⬆️
.../assets/src/SqlLab/components/TabbedSqlEditors.jsx 83.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b210742...f0ac375. Read the comment docs.

@john-bodley
Copy link
Member

john-bodley commented Mar 21, 2019

@dpgaspar would you mind running,

pip-compile --output-file requirements.txt setup.py

to ensure that we pull in all the updated dependencies for Flask-AppBuilder version 1.12.5? Note you may also need to bump pip-tools to version 3.5.0 in requirements-dev.txt due a related pip issue.

@dpgaspar
Copy link
Member Author

no problem!

@mistercrunch mistercrunch merged commit 10d0033 into apache:master Mar 22, 2019
@dpgaspar dpgaspar deleted the fab_1.12.5 branch March 22, 2019 23:43
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants