[mypy] Adding mypy type checking #7053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--mypy
branch
9 times, most recently
from
c24d741 to
c8cd3af
Compare
Codecov Report
@@ Coverage Diff @@
## master #7053 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 421 421
Lines 20537 20537
Branches 2247 2247
=======================================
Hits 13240 13240
Misses 7170 7170
Partials 127 127
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--mypy
branch
from
4b7ac67 to
177e7c0
Compare
john-bodley
force-pushed
the
john-bodley--mypy
branch
from
177e7c0 to
2f02278
Compare
| @@ -462,6 +462,35 @@ Note that the test environment uses a temporary directory for defining the | |||
| SQLite databases which will be cleared each time before the group of test | |||
| commands are invoked. | |||
|
|
|||
| #### Typing | |||
|
|
|||
| To ensure clarity, consistency, all readability, _all_ new functions should use | |||
There was a problem hiding this comment.
Personally I'm happy with this. Can we kick off a [DISCUSS] thread on the mailing list though, making sure we have consensus?
|
LGTM ! |
|
I'm merging this as I'd like to play around with mypy and add some type annotations to some |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
mypy(courtesy offlake8) for checking Python type hints. Additionally it updates theCONTRIBUTING.mdto strongly encourage new Python functions to use type hints.Note I corrected some
mypyissues but ignored others as I don't have full context into the code. Theget_since_untilmethod seems to be especially problematic partially becausesince,until, andrelative_endare being re-typed in the function (which is probably non-ideal).to: @betodealmeida @michellethomas @mistercrunch @xtinec