Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use HTTPS, not HTTP wherever practical #7040

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

hajdbo
Copy link
Contributor

@hajdbo hajdbo commented Mar 15, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #7040 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7040   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files         421      421           
  Lines       20524    20524           
  Branches     2245     2245           
=======================================
  Hits        13230    13230           
  Misses       7167     7167           
  Partials      127      127
Impacted Files Coverage Δ
superset/extract_table_names.py 0% <ø> (ø) ⬆️
superset/db_engine_specs.py 56.88% <ø> (ø) ⬆️
superset/assets/src/modules/geo.js 77.27% <ø> (ø) ⬆️
superset/assets/src/addSlice/AddSliceContainer.jsx 72.72% <ø> (ø) ⬆️
superset/config.py 93.71% <ø> (ø) ⬆️
...ets/src/SqlLab/components/TemplateParamsEditor.jsx 85.29% <ø> (ø) ⬆️
superset/migrations/env.py 0% <ø> (ø) ⬆️
superset/views/core.py 74.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d48d4...a8a3001. Read the comment docs.

@hajdbo hajdbo changed the title Download RAT binary via HTTPS, not HTTP [fix] Use HTTPS, not HTTP wherever practical Mar 15, 2019
@kristw
Copy link
Contributor

kristw commented Mar 15, 2019

package-lock.json is auto-generated by npm. Your changes will be overridden next time we change dependency. I would suggest removing it from this PR.

@hajdbo
Copy link
Contributor Author

hajdbo commented Mar 18, 2019

package-lock.json is auto-generated by npm. Your changes will be overridden next time we change dependency. I would suggest removing it from this PR.

Done, thanks for the tip.

@mistercrunch
Copy link
Member

Did you test that all the altered links work? Some static/doc website still don't support https sometimes...

@hajdbo
Copy link
Contributor Author

hajdbo commented Mar 18, 2019

Did you test that all the altered links work? Some static/doc website still don't support https sometimes...

I tested all, manually. I did not change the http links when the website did not accept https. I also did not change the Apache http links, even though apache.org supports https, because the official licence text still points to the http:// address

@mistercrunch mistercrunch merged commit 5137539 into apache:master Mar 18, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants