Bump sqlalchemy dependency #7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7000 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 421 421
Lines 20521 20521
Branches 2245 2245
=======================================
Hits 13229 13229
Misses 7165 7165
Partials 127 127Continue to review full report at Codecov.
|
villebro
reviewed
Mar 8, 2019
setup.py
Outdated
| @@ -100,7 +100,7 @@ def get_git_sha(): | |||
| 'retry>=0.9.2', | |||
| 'selenium>=3.141.0', | |||
| 'simplejson>=3.15.0', | |||
| 'sqlalchemy', | |||
| 'sqlalchemy>=1.2.18, <2.0.0', | |||
There was a problem hiding this comment.
sqlalchemy==1.3.0 just came out and is having some teething problems. I would suggest restricting to <1.3.0 until those are sorted out, otherwise pip will pull in the 1.3 version.
|
Addressed the comments. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6977