Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iframe and markup legacy plugin #6741

Merged
merged 5 commits into from
Jan 23, 2019
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jan 23, 2019

Add iframe plugin back for backward-compatibility.

@michellethomas @williaster @graceguo-supercat

@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community .vis v0.30 labels Jan 23, 2019
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kristw kristw changed the title Add iframe legacy plugin Add iframe and markup legacy plugin Jan 23, 2019
@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #6741 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6741      +/-   ##
==========================================
- Coverage   56.11%   56.07%   -0.04%     
==========================================
  Files         521      525       +4     
  Lines       23197    23212      +15     
  Branches     2777     2776       -1     
==========================================
  Hits        13016    13016              
- Misses       9772     9787      +15     
  Partials      409      409
Impacted Files Coverage Δ
...perset/assets/src/visualizations/Markup/Markup.jsx 0% <0%> (ø)
...assets/src/visualizations/Markup/transformProps.js 0% <0%> (ø)
...ts/src/visualizations/presets/LegacyChartPreset.js 0% <0%> (ø) ⬆️
...ets/src/visualizations/Iframe/IframeChartPlugin.js 0% <0%> (ø)
...assets/src/visualizations/Iframe/transformProps.js 0% <0%> (ø)
...perset/assets/src/visualizations/Iframe/Iframe.jsx 0% <0%> (ø)
...ets/src/visualizations/Markup/MarkupChartPlugin.js 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab7ee7...585c1d2. Read the comment docs.

@kristw kristw added the review label Jan 23, 2019
@kristw kristw merged commit 3ae7d32 into apache:master Jan 23, 2019
@kristw kristw deleted the kristw--iframe branch January 23, 2019 18:22
michellethomas pushed a commit that referenced this pull request Jan 23, 2019
* Add iframe plugin

* Use lazy load and add description

* remove unintended files

* Add markup

* minor adjustment

(cherry picked from commit 3ae7d32)
@xtinec xtinec added the v0.31 label Feb 1, 2019
xtinec pushed a commit that referenced this pull request Feb 1, 2019
* Add iframe plugin

* Use lazy load and add description

* remove unintended files

* Add markup

* minor adjustment

(cherry picked from commit 3ae7d32)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Add iframe plugin

* Use lazy load and add description

* remove unintended files

* Add markup

* minor adjustment

(cherry picked from commit 5ca8dfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community v0.30 v0.31 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants