-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc about translation using poedit #6600
Conversation
delete the 'null,' in messages.json, so that word can be translate in js.
delete the 'null,' in messages.json, so that word can be translate in js.
Synchronize from superset
Codecov Report
@@ Coverage Diff @@
## master #6600 +/- ##
=======================================
Coverage 56.24% 56.24%
=======================================
Files 518 518
Lines 23007 23007
Branches 2750 2750
=======================================
Hits 12941 12941
Misses 9655 9655
Partials 411 411 Continue to review full report at Codecov.
|
just add some document at CONTRIBUTING.md @mistercrunch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some typos
fix typos
thanks @kakoni , but , i am freshman to use github pull request, can you to help me learn more about PR by suggest some resource. thank you very much. |
@zhouyao1994 Do you mean to tag me? Thank you for updating the doc. It seems like you are doing well on figuring out how to update the PR. Just make sure the text is updated as suggested. |
Also let's break the lines. |
if i want to fix the typos ,and merge the changes in CONTRIBUTING.md,
|
sorry , i am not understand what you mean. Are you seggest me to add some lines in the CONTRIBUTING.md? can you describe more detail.thank you very much. |
Hi @zhouyao1994 , the po file is a plain Text, why we need |
Yes it is just a plaint text ,but I think if you have try poedit ,you just know why,
|
By breaking the line I just mean instead of writing one long paragraph as a single line with a As far as updating your PR, you add a commit to your branch and then push it to your fork and it will update the PR. There are a lot of resources out there to learn how to use Git/ Github. |
syn from apache superset
Oh yes , i understand, thianks. |
merge from master
merge from upstream
i just update the document ,is this right? @kristw |
add some suggestion in CONTRIBUTING.md, use poedit can accelerate ranslation. The poedit website show a lot of feature . the poedit is all platform software,Mac,Ubuntu,Windows are supported. i help this document can help more people to contribute translate.