Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc about translation using poedit #6600

Merged
merged 12 commits into from
Jan 14, 2019
Merged

Conversation

zhouyao1994
Copy link
Contributor

add some suggestion in CONTRIBUTING.md, use poedit can accelerate ranslation. The poedit website show a lot of feature . the poedit is all platform software,Mac,Ubuntu,Windows are supported. i help this document can help more people to contribute translate.

zhouyao1994 and others added 5 commits January 5, 2019 22:42
delete the 'null,' in messages.json,
so that word can be translate in js.
delete the 'null,' in messages.json,
so that word can be translate in js.
Synchronize from superset
@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #6600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6600   +/-   ##
=======================================
  Coverage   56.24%   56.24%           
=======================================
  Files         518      518           
  Lines       23007    23007           
  Branches     2750     2750           
=======================================
  Hits        12941    12941           
  Misses       9655     9655           
  Partials      411      411

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ce997...ea6d8b7. Read the comment docs.

@zhouyao1994
Copy link
Contributor Author

just add some document at CONTRIBUTING.md @mistercrunch
about the use of poedit and remove 'null,' in message.json

Copy link
Contributor

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos

@zhouyao1994
Copy link
Contributor Author

thanks @kakoni , but , i am freshman to use github pull request, can you to help me learn more about PR by suggest some resource. thank you very much.

@kristw
Copy link
Contributor

kristw commented Jan 7, 2019

@zhouyao1994 Do you mean to tag me?

Thank you for updating the doc. It seems like you are doing well on figuring out how to update the PR. Just make sure the text is updated as suggested.

@kristw kristw changed the title accelerate translate by poedit Add doc about translation using poedit Jan 7, 2019
@mistercrunch
Copy link
Member

Also let's break the lines.

@zhouyao1994
Copy link
Contributor Author

zhouyao1994 commented Jan 8, 2019

if i want to fix the typos ,and merge the changes in CONTRIBUTING.md,
Is the todolist right?

  • 1. clone and check out translate-zh branch in my repository
  • 2. fix the typos in CONTRIBUTING.md,and change the PR title as @kakoni suggest.
  • 3. reopen a pull request?

@zhouyao1994
Copy link
Contributor Author

Also let's break the lines.

sorry , i am not understand what you mean.

Are you seggest me to add some lines in the CONTRIBUTING.md?

can you describe more detail.thank you very much.

@zhaoyongjie
Copy link
Member

Hi @zhouyao1994 , the po file is a plain Text, why we need poedit to edit this file.

@zhouyao1994
Copy link
Contributor Author

#6597

Hi @zhouyao1994 , the po file is a plain Text, why we need poedit to edit this file.

Yes it is just a plaint text ,but I think if you have try poedit ,you just know why,
the poedit have a lot of great feature.

  1. can pre-translate from history
  2. can use microsoft translate to help you pre-translate
  3. have UI
  4. auto convert pofile to mo file

@mistercrunch
Copy link
Member

By breaking the line I just mean instead of writing one long paragraph as a single line with a \n at the very end, break each line at 80-100 chars like in the rest of the file.

As far as updating your PR, you add a commit to your branch and then push it to your fork and it will update the PR. There are a lot of resources out there to learn how to use Git/ Github.

@zhouyao1994
Copy link
Contributor Author

By breaking the line I just mean instead of writing one long paragraph as a single line with a \n at the very end, break each line at 80-100 chars like in the rest of the file.

As far as updating your PR, you add a commit to your branch and then push it to your fork and it will update the PR. There are a lot of resources out there to learn how to use Git/ Github.

Oh yes , i understand, thianks.

@zhouyao1994
Copy link
Contributor Author

i just update the document ,is this right? @kristw

@kristw kristw merged commit f480a52 into apache:master Jan 14, 2019
@zhouyao1994 zhouyao1994 deleted the translate-zh branch January 15, 2019 01:48
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants