Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #6590: Numeric values in columns sometimes returned as quoted strings #6591

Merged
merged 7 commits into from
Jan 14, 2019
Merged

Fix for #6590: Numeric values in columns sometimes returned as quoted strings #6591

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fe0272
Update CONTRIBUTING.md
soboko Dec 18, 2018
f55e181
Part of fix for https://github.com/apache/incubator-superset/issues/6…
Jan 3, 2019
cfe048c
Bumped version of superset-ui-connector
Jan 9, 2019
81f721d
Updated package-lock,json
Jan 9, 2019
c22077f
Removed unused import (linting issue)
Jan 9, 2019
7fb2bc2
Added @babel/polyfill import
Jan 9, 2019
e9acd3c
Reset mock history before each test, not after each test
Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unused import (linting issue)
  • Loading branch information
chris_council committed Jan 9, 2019
commit c22077ff253ab68666e01ec0572f0eba683f24c6
1 change: 0 additions & 1 deletion superset/assets/src/SqlLab/actions/sqlLab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import shortid from 'shortid';
import JSONbig from 'json-bigint';
Copy link
Contributor

@williaster williaster Jan 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also now remove this dependency? EDIT: maybe not since you still use it below.

import { t } from '@superset-ui/translation';
import { SupersetClient } from '@superset-ui/connection';

Expand Down