Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the cannot-overwrite error message from being removed #626

Merged
merged 1 commit into from
Jun 15, 2016

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Jun 15, 2016

There was 2 problems about the cannot-overwrite error message

  1. No alert-danger CSS, so the message is in white with white background
  2. It's removed right after the page is loaded, before the user can see it
    This PR attempts to fix these two issues

@coveralls
Copy link

coveralls commented Jun 15, 2016

Coverage Status

Coverage remained the same at 81.962% when pulling 6880553 on x4base:show_overwrite_error into a117498 on airbnb:master.

@mistercrunch mistercrunch merged commit ee2d333 into apache:master Jun 15, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
Bumps [jest-mock-console](https://github.com/bpedersen/jest-mock-console) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/bpedersen/jest-mock-console/releases)
- [Commits](https://github.com/bpedersen/jest-mock-console/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
Bumps [jest-mock-console](https://github.com/bpedersen/jest-mock-console) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/bpedersen/jest-mock-console/releases)
- [Commits](https://github.com/bpedersen/jest-mock-console/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
Bumps [jest-mock-console](https://github.com/bpedersen/jest-mock-console) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/bpedersen/jest-mock-console/releases)
- [Commits](https://github.com/bpedersen/jest-mock-console/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Bumps [jest-mock-console](https://github.com/bpedersen/jest-mock-console) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/bpedersen/jest-mock-console/releases)
- [Commits](https://github.com/bpedersen/jest-mock-console/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants