-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate translation module @superset-ui/translation #6222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6222 +/- ##
==========================================
- Coverage 76.87% 76.85% -0.02%
==========================================
Files 47 47
Lines 9401 9393 -8
==========================================
- Hits 7227 7219 -8
Misses 2174 2174
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one question about bootstrap data but LGTM overall! 💯 🚀
* add translation modules * Update package.json * Update instructions in CONTRIBUTING * Remove old files * Add new entry point "translation" * Change imports * move setupTranslation code * remove translation from entry * Update python template * Refactor utils into smaller, independent files * Define preamble * working state * combine toggleCheckbox with setupApp * move code block out of document.ready * move setupClient to preamble * fix unit tests * update package version * delete deletion code
Import
@superset-ui/translation
moduleto
Update webpack build config
preamble.js
which defines the steps that has to happen before everything else (e.g.configure
the translation module)preamble
.common
entry point and create a new entry pointpreamble
.base.html
andbasic.html
)common
entry point from the page that has an entry point (becausepreamble
is now included with all entry points). Prior to this PR, Superset imports bothcommon
and another entry point (explore
,dashboard
, etc.) in a single page. With this PR, it will no longer importcommon
.common
withpreamble
for the page that doesn't have another entry point. (base.html
)getClientErrorObject
and error message strings into separate files.@williaster @xtinec @conglei @graceguo-supercat @michellethomas