Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate getColorFromScheme #5937

Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 20, 2018

All calls to this function getColorFromScheme was replaced with getColor or getScale from CategoricalColorNamespace in PR #5815 .

This function was left as a shim in PR #5815, as there were still some components using it. Now all those remaining calls have been removed so there is no need for this shim anymore.

p.s. also enable all unit tests again after .only was left in one of the tests.

@williaster @conglei

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #5937 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5937      +/-   ##
==========================================
- Coverage   63.58%   63.56%   -0.02%     
==========================================
  Files         393      393              
  Lines       23674    23667       -7     
  Branches     2639     2638       -1     
==========================================
- Hits        15053    15044       -9     
- Misses       8608     8610       +2     
  Partials       13       13
Impacted Files Coverage Δ
superset/assets/src/modules/colors.js 51.72% <ø> (-9.39%) ⬇️
...set/assets/src/modules/colorSchemes/categorical.js 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c62494...45ac79c. Read the comment docs.

@kristw kristw force-pushed the kristw-deprecate-getcolorfromscheme branch from c6de9e9 to 10a49ef Compare September 21, 2018 17:51
@kristw kristw closed this Sep 21, 2018
@kristw kristw reopened this Sep 21, 2018
@kristw kristw closed this Sep 21, 2018
@kristw kristw reopened this Sep 21, 2018
@kristw kristw force-pushed the kristw-deprecate-getcolorfromscheme branch from 10a49ef to 45ac79c Compare September 21, 2018 20:50
@kristw kristw closed this Sep 21, 2018
@kristw kristw reopened this Sep 21, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@williaster williaster merged commit 6b89b7f into apache:master Sep 23, 2018
@kristw kristw deleted the kristw-deprecate-getcolorfromscheme branch September 25, 2018 21:46
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants