Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix percent metric display and check for string columns in table #5917

Merged
merged 3 commits into from
Sep 18, 2018
Merged

[bugfix] Fix percent metric display and check for string columns in table #5917

merged 3 commits into from
Sep 18, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 17, 2018 •
edited
Loading

SUPERSET-695

For the visualization type Table View, this slice, used to automatically convert some values into %s (e.g., 55%) because the column names (like % Visit had the phrase % in it. This was ideal for my use case.

However, now I noticed that these values’ format recently auto-changed to mm, e.g., 550mm. Is there a way to change these values back to the former percentages?

This was fixed by reverting the inadvertent change made during refactor (if => else if)

As well as another bug to filter out columns that are not numbers.

Reference:
https://github.com/apache/incubator-superset/pull/5707/files

@graceguo-supercat

graceguo-supercat
graceguo-supercat approved these changes Sep 17, 2018
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristw kristw changed the title [bugfix] Fix percent metric display in table [bugfix] Fix percent metric display and check for string columns in table Sep 18, 2018
@kristw kristw closed this Sep 18, 2018
@kristw kristw reopened this Sep 18, 2018
@kristw kristw closed this Sep 18, 2018
@kristw kristw reopened this Sep 18, 2018
@kristw kristw closed this Sep 18, 2018
@kristw kristw reopened this Sep 18, 2018
@kristw
Copy link
Contributor Author

kristw commented Sep 18, 2018

Finally CI is green again. 🙌

@graceguo-supercat graceguo-supercat merged commit 19a3319 into apache:master Sep 18, 2018
@kristw kristw deleted the kristw-fix-table branch September 18, 2018 19:04
@kristw kristw mentioned this pull request Sep 18, 2018
Merged
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 18, 2018
@kristw
[bugfix] Fix percent metric display and check for string columns in t…
248a45d 
…able (apache#5917)

* fix percent metric display

* add empty line

* address string or number check

(cherry picked from commit 19a3319)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@kristw @betodealmeida
[bugfix] Fix percent metric display and check for string columns in t…
b50170e 
…able (apache#5917)

* fix percent metric display

* add empty line

* address string or number check
@laxmanraparthi laxmanraparthi mentioned this pull request Oct 28, 2023
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristw @graceguo-supercat @mistercrunch