Remove unused functions and jquery dependency #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to wait for nvd3 PR |
|
@kristw will review the nvd3 pr tmr ! |
kristw
force-pushed
the
kristw-remove-fn
branch
from
13fe96a
to
6c8bd4a
Compare
kristw
force-pushed
the
kristw-remove-fn
branch
from
6c8bd4a
to
13e73cc
Compare
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* remove unused functions and jquery dependency * rebase and remove more obsolete functions
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
get,findandshoware not used any more after the SIP-5 refactor.@williaster @conglei @graceguo-supercat