Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIP-5] Refactor nvd3 #5838

Merged
merged 44 commits into from
Sep 17, 2018
Merged

[SIP-5] Refactor nvd3 #5838

merged 44 commits into from
Sep 17, 2018

Commits on Sep 13, 2018

  1. move into folder and scaffold adaptor

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    15a337d View commit details
    Browse the repository at this point in the history

  2. extract width and height

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    b52adec View commit details
    Browse the repository at this point in the history

  3. remove jquery

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    c62b075 View commit details
    Browse the repository at this point in the history

  4. extract showBrush

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    697391a View commit details
    Browse the repository at this point in the history

  5. extract lineInterpolation

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ac2c4a7 View commit details
    Browse the repository at this point in the history

  6. extract xAxisFormat and yAxisFormat

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    d187306 View commit details
    Browse the repository at this point in the history

  7. extract annotationData

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    59b9c22 View commit details
    Browse the repository at this point in the history

  8. extract xTicksLayout and colorScheme

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    f16deeb View commit details
    Browse the repository at this point in the history

  9. extract showXXX

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    f5fafb2 View commit details
    Browse the repository at this point in the history

  10. extract x and y axis labels

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    7d330b7 View commit details
    Browse the repository at this point in the history

  11. extract showminmax

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    672234b View commit details
    Browse the repository at this point in the history

  12. extract pie chart props

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5bf69e6 View commit details
    Browse the repository at this point in the history

  13. extract area chart props

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    b907bee View commit details
    Browse the repository at this point in the history

  14. extract logscale and yAxisBounds

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    0116d00 View commit details
    Browse the repository at this point in the history

  15. extract margin

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    eb23184 View commit details
    Browse the repository at this point in the history

  16. extract bubble props x,y,size

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    e0db6b7 View commit details
    Browse the repository at this point in the history

  17. extract contribution, comparisonType and color_picker

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ea3e6ef View commit details
    Browse the repository at this point in the history

  18. remove the last fd.xxx

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    1dafe0f View commit details
    Browse the repository at this point in the history

  19. remove unnecessary variables

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ffdb7d4 View commit details
    Browse the repository at this point in the history

  20. remove slice.container

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    472338c View commit details
    Browse the repository at this point in the history

  21. fix unit test reference

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    4c21492 View commit details
    Browse the repository at this point in the history

  22. Rewrite logic to compute max label lengths to use only d3, not jquery.

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    e998d22 View commit details
    Browse the repository at this point in the history

  23. extract annotationLayers and no more slice.xxx in nvd3vis

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    595f40e View commit details
    Browse the repository at this point in the history

  24. rename x, y, size to xField, yField, sizeField

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    d233223 View commit details
    Browse the repository at this point in the history

  25. use arrow function

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ae2c8bd View commit details
    Browse the repository at this point in the history

  26. move tooltip function

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    98d5a6b View commit details
    Browse the repository at this point in the history

  27. extract helper functions into utils

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    3416f02 View commit details
    Browse the repository at this point in the history

  28. remove unused argument

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    34f447b View commit details
    Browse the repository at this point in the history

  29. fix height calculation and show bar labels

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    1cd2394 View commit details
    Browse the repository at this point in the history

  30. rename function

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ab4c7a0 View commit details
    Browse the repository at this point in the history

  31. update unit test

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    203f229 View commit details
    Browse the repository at this point in the history

  32. organize tooltip generator

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    fce3ca2 View commit details
    Browse the repository at this point in the history

  33. update line_multi

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    3696ccc View commit details
    Browse the repository at this point in the history

  34. Add proptypes for data

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    48540f5 View commit details
    Browse the repository at this point in the history

  35. list proptypes for data

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    be450fe View commit details
    Browse the repository at this point in the history

  36. extract tooltip function for bubble chart

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    73ebb13 View commit details
    Browse the repository at this point in the history

  37. rename variables

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    b28c08e View commit details
    Browse the repository at this point in the history

  38. remove console.log

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    dfab7e3 View commit details
    Browse the repository at this point in the history

  39. enumerate vizTypes and pieLabelType

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    4c45f5f View commit details
    Browse the repository at this point in the history

  40. merge master and resolved conflicts

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    a085593 View commit details
    Browse the repository at this point in the history

  41. parse maxBubble

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ed9fb95 View commit details
    Browse the repository at this point in the history

  42. use new color scale

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    22435a9 View commit details
    Browse the repository at this point in the history

  43. fix import"

    @kristw
    kristw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    cde5136 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. remove line

    @kristw
    kristw committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    58214bd View commit details
    Browse the repository at this point in the history