Linting #5790
Merged
Linting #5790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
fix_alerts
branch
from
d72e683
to
56094a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
+ Coverage 63.78% 63.78% +<.01%
==========================================
Files 364 364
Lines 23111 23101 -10
Branches 2587 2587
==========================================
- Hits 14741 14735 -6
+ Misses 8355 8351 -4
Partials 15 15
Continue to review full report at Codecov.
|
mistercrunch
commented
Sep 19, 2018
| const wrapper = shallow(<ExploreResultsButton {...emptyQuery} />, { | ||
| context: { store }, | ||
| }).dive(); | ||
| expect(wrapper.state().hints).to.deep.equal([]); |
There was a problem hiding this comment.
Hints was unused in the component.
mistercrunch
commented
Sep 19, 2018
| @@ -28,9 +28,6 @@ const defaultProps = { | |||
| class ExploreResultsButton extends React.PureComponent { | |||
| constructor(props) { | |||
| super(props); | |||
| this.state = { | |||
| hints: [], | |||
There was a problem hiding this comment.
hints is unused in the component
hughhhh
reviewed
Sep 20, 2018
| @@ -6,6 +6,10 @@ | |||
| Create Date: 2016-05-27 15:03:32.980343 | |||
|
|
|||
| """ | |||
| from __future__ import absolute_import | |||
There was a problem hiding this comment.
nit: puts these inline
from __future__ import absolute_import, division, print_function, unicode_literals
There was a problem hiding this comment.
Somehow it's not the standard and I think the linter would complain. Not quite sure why though.
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this https://lgtm.com/projects/g/airbnb/caravel/alerts/?mode=list and started hammering at it to see what it's all about.
Related, there's more work to do, opened an issue here: #5791