Superset issue #4354 - Properly filter datasources #4355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter datasources on /datasources/ endpoint
Filter datasources on /slicemodelview/add endpoint
|
It would be very nice to add some tests to avoid regressions :) |
|
Could you point me the best place for tests ? |
|
superset.tests.core_tests looks like a place for testing views permissions handling |
maver1ck
changed the title
|
@xrmx |
|
@maver1ck AFAIR access_tests are specfic to inviting people to access a dashboard |
|
Closing this because of #4565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4354
Properly filter datasources