fix(Dataset Folders): improve search-collapse

[msyavuz]

SUMMARY

This PR improves the search functionality in dataset folders within the Explore view. Previously, searching for metrics/columns in collapsed folders would not show results, and the folder structure made it difficult to find matching items. This has been a significant usability issue preventing adoption of the dataset folders feature.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

dataset-folders-before.mp4

After:

dataset-folders-after.mp4

TESTING INSTRUCTIONS

2. Create or use existing folder structure with nested folders
3. Collapse some folders
4. Search for a metric/column name that's inside a collapsed folder
   - Verify the folder auto-expands to show the match
   - Verify folders without matches are hidden
5. Search for a folder name (e.g., "Metrics")
   - Verify all children in that folder are shown
6. Clear the search
   - Verify folders return to their original collapsed/expanded state

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: DATASET_FOLDERS
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

FEATURE_DATASET_FOLDERS=true

[bito-code-review]

Code Review Agent Run #9b2c0e

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: b0b5cf2..67c3094

  • superset-frontend/src/components/Datasource/FoldersEditor/FoldersEditor.test.tsx
  • superset-frontend/src/components/Datasource/FoldersEditor/index.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by