fix(sqla): parenthesize extras where/having clauses in query generation#38183
Draft
fix(sqla): parenthesize extras where/having clauses in query generation#38183
Conversation
When extras.where or extras.having clauses are combined with other query filters using AND, the resulting SQL can produce unexpected evaluation order due to SQL operator precedence. This wraps user-supplied WHERE and HAVING expressions in parentheses to ensure they are treated as a single logical unit when composed with other clauses. Also fixes a minor issue where iterating over filter could fail if None was passed instead of an empty list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace raw string wrapping f"({expr})" with SQLAlchemy's Grouping
construct to parenthesize extras where/having clauses. Grouping is the
proper abstraction layer for this — it lets SQLAlchemy handle
parenthesization in a dialect-agnostic way rather than doing string
surgery on raw SQL text.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extras.where or extras.having clauses are combined with other query filters using AND, the resulting SQL can produce unexpected evaluation order due to SQL operator precedence.
This wraps user-supplied WHERE and HAVING expressions in parentheses to ensure they are treated as a single logical unit when composed with other clauses.
Also fixes a minor issue where iterating over filter could fail if None was passed instead of an empty list.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION