Skip to content

feat(ci): only run precommit on changed files #38155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hainenber wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −4
Open

feat(ci): only run precommit on changed files #38155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91ca9e5
feat(ci): only run precommit on change files
hainenber Feb 21, 2026
c94d3cc
fix(ci): correct action name to collect changed file names
hainenber Feb 22, 2026
9eaa19c
chore: resolve `jsx-a11y/role-has-required-aria-props` lint issues
hainenber Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,17 @@ jobs:
restore-keys: |
pre-commit-v2-${{ runner.os }}-py${{ matrix.python-version }}-

- name: Get changed files
id: changed_files
uses: ./.github/actions/file-changes-action
with:
output: ' '

- name: pre-commit
run: |
set +e # Don't exit immediately on failure
export SKIP=eslint-frontend,type-checking-frontend
pre-commit run --all-files
export SKIP=type-checking-frontend
pre-commit run --files ${{ steps.changed_files.outputs.files }}
PRE_COMMIT_EXIT_CODE=$?
git diff --quiet --exit-code
GIT_DIFF_EXIT_CODE=$?
Expand Down
3 changes: 1 addition & 2 deletions superset-frontend/oxlint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@
"jsx-a11y/no-noninteractive-tabindex": "error",
"jsx-a11y/no-redundant-roles": "error",
"jsx-a11y/no-static-element-interactions": "off",
// TODO: Fix missing aria-selected on tab roles
"jsx-a11y/role-has-required-aria-props": "warn",
"jsx-a11y/role-has-required-aria-props": "error",
"jsx-a11y/role-supports-aria-props": "error",
"jsx-a11y/scope": "error",
"jsx-a11y/tabindex-no-positive": "error",
Expand Down
1 change: 1 addition & 0 deletions ...ontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ const FilterTitleContainer = forwardRef<HTMLDivElement, Props>(
key={`filter-title-tab-${id}`}
onClick={() => onChange(id)}
className={classNames.join(' ')}
aria-selected={isActive}
>
<div css={{ display: 'flex', width: '100%', alignItems: 'center' }}>
<div
Expand Down
1 change: 1 addition & 0 deletions ...frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ItemTitleContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ const ItemTitleContainer = forwardRef<HTMLDivElement, Props>(
key={`item-title-tab-${id}`}
onClick={() => onChange(id)}
className={classNames.join(' ')}
aria-selected={isActive}
>
<div css={{ display: 'flex', width: '100%', alignItems: 'center' }}>
<div
Expand Down
Loading