build(deps): update geostyler-* deps to latest major versions

[hainenber]

build(deps): update geostyler-* deps to latest major versions

SUMMARY

Update all geostyler-related deps to their latest version. This helps trimming off outdated/vuln-affected deps thanks to upstream (~20 deps) whilst keeping the functionality for Cartodiagram chart plugin to be intact.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Cartodiagram plugin still renders and hovering tooltip shows correct data

TESTING INSTRUCTIONS

1. Create table with geom column
2. FIll sample data
3. Create a pie chart as a sample chart
4. Create further cartodiagram chart for visualization

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #932bd3

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: e740f77..e740f77

  • superset-frontend/webpack.config.js
• Files skipped - 3

  • superset-frontend/package-lock.json - Reason: Filter setting
  • superset-frontend/package.json - Reason: Filter setting
  • superset-frontend/plugins/plugin-chart-cartodiagram/package.json - Reason: Filter setting
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[dosubot]

Related Documentation

Checked 0 published document(s) in 2 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[codeant-ai-for-open-source]

Sequence Diagram

This PR upgrades multiple geostyler-related packages and updates webpack resolver rules so the frontend build loads newer geostyler parser/style modules correctly; the main effect is the build and Cartodiagram chart plugin using the updated geostyler libraries to render visualizations unchanged.

sequenceDiagram
    participant Dev/CI
    participant PackageManager
    participant Webpack
    participant CartodiagramPlugin
    participant GeostylerLibs

    Dev/CI->>PackageManager: Update geostyler-* versions in package.json
    PackageManager-->>Dev/CI: Install updated geostyler packages
    Dev/CI->>Webpack: Apply updated imports/resolve rule for geostyler modules
    CartodiagramPlugin->>GeostylerLibs: Import & use geostyler parsers/styles at runtime
    Webpack->>GeostylerLibs: Bundle newer geostyler modules (resolved by updated rule)
    GeostylerLibs-->>CartodiagramPlugin: Provide parsing/styling capabilities
    CartodiagramPlugin-->>Dev/CI: Render cartodiagram (visual verification)

Loading

---

Generated by CodeAnt AI

[hainenber]

Ugh, Jest not playing nice with ESM-only packages. Working on it.

[bito-code-review]

Code Review Agent Run #700fe2

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/jest.config.js - 1

  • Incorrect Jest transform regex · Line 67-67
    The added regex pattern '(?!geostyler)lodash' in transformIgnorePatterns appears incorrect or unnecessary. It may not achieve the intended exclusion of geostyler-related lodash paths, as geostyler packages are already handled separately. Consider simplifying to just 'lodash' to ensure lodash modules are properly transformed for Jest tests.
    Code suggestion

     @@ -67,1 +67,1 @@
    -    'node_modules/(?!d3-(array|interpolate|color|time|scale|time-format|format)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|uuid|@rjsf/*.|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|(?!geostyler)lodash|react-error-boundary|react-json-tree|react-base16-styling|lodash-es|rbush|quickselect)',
    +    'node_modules/(?!d3-(array|interpolate|color|time|scale|time-format|format)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|uuid|@rjsf/*.|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|lodash|react-error-boundary|react-json-tree|react-base16-styling|lodash-es|rbush|quickselect)',

Review Details

• Files reviewed - 2 · Commit Range: e740f77..c3ec4a9

  • superset-frontend/jest.config.js
  • superset-frontend/webpack.config.js
• Files skipped - 4

  • .github/dependabot.yml - Reason: Filter setting
  • superset-frontend/package-lock.json - Reason: Filter setting
  • superset-frontend/package.json - Reason: Filter setting
  • superset-frontend/plugins/plugin-chart-cartodiagram/package.json - Reason: Filter setting
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by