refactor: consolidating ColorSchemeEnum settings into one place

[SBIN2010]

SUMMARY

The ColorSchemeEnum declarations, which were duplicated, have been merged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codeant-ai-for-open-source]

Sequence Diagram

The PR centralizes duplicate ColorSchemeEnum definitions into the @superset-ui/chart-controls package. Plugins and UI controls now import the single enum and use it for conditional formatting and control panels.

sequenceDiagram
    participant Plugin as Plugin (Table / AgGrid / ECharts)
    participant ChartControls as @superset-ui/chart-controls
    participant UI as Explore UI / FormattingPopover
    participant Test as Unit Tests / ControlPanel tests

    Plugin->>ChartControls: import ColorSchemeEnum
    ChartControls-->>Plugin: exports central ColorSchemeEnum
    Plugin->>UI: use ColorSchemeEnum for conditional formatting & control panel options
    UI-->>Plugin: render controls / formatting using enum values
    Test->>Plugin: import config that references ColorSchemeEnum
    Test-->>ChartControls: resolves enum import (ensures single source)

Loading

---

Generated by CodeAnt AI

[bito-code-review]

Code Review Agent Run #ea0a37

Actionable Suggestions - 0

Review Details

• Files reviewed - 14 · Commit Range: 51bf1c2..51bf1c2

  • superset-frontend/packages/superset-ui-chart-controls/src/types.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/types.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/test/controlPanel.test.tsx
  • superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts
  • superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/types.ts
  • superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
  • superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
  • superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
  • superset-frontend/plugins/plugin-chart-table/src/types.ts
  • superset-frontend/plugins/plugin-chart-table/test/controlPanel.test.tsx
  • superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.test.tsx
  • superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #102d42

Actionable Suggestions - 0

Review Details

• Files reviewed - 15 · Commit Range: 51bf1c2..53d5f93

  • superset-frontend/packages/superset-ui-chart-controls/src/types.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/types.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/test/controlPanel.test.tsx
  • superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/PopKPI.tsx
  • superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts
  • superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/types.ts
  • superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
  • superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
  • superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
  • superset-frontend/plugins/plugin-chart-table/src/types.ts
  • superset-frontend/plugins/plugin-chart-table/test/controlPanel.test.tsx
  • superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.test.tsx
  • superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[github-actions]

🎪 Showtime is building environment on GHA for 53d5f93